Skip to content

chore: support specifying nodeport for the file-server service #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nic-chen merged 2 commits into from
Apr 26, 2026
Merged

chore: support specifying nodeport for the file-server service #282

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4327fad
chore: support specifying nodeport for the file-server service
nic-chen Apr 26, 2026
c1e202e
f
nic-chen Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/api7/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.17.52
version: 0.17.53

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
1 change: 1 addition & 0 deletions charts/api7/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ A Helm chart for Kubernetes
| file_server_configuration.file_server.listen | string | `"0.0.0.0:8080"` | |
| file_server_configuration.log.level | string | `"warn"` | |
| file_server_configuration.log.output | string | `"stderr"` | |
| file_server_service.nodePort | int | `nil` | The nodePort for HTTP service, only used if file_server_service.type is NodePort. If not set, a random port will be assigned by Kubernetes. |
| file_server_service.port | int | `8080` | |
| file_server_service.type | string | `"ClusterIP"` | |
| fullnameOverride | string | `""` | |
Expand Down
3 changes: 3 additions & 0 deletions charts/api7/templates/file-server-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ spec:
targetPort: http
protocol: TCP
name: http
{{- if (and (eq .Values.file_server_service.type "NodePort") (not (empty .Values.file_server_service.nodePort))) }}
nodePort: {{ .Values.file_server_service.nodePort }}
{{- end }}
selector:
{{- include "api7ee3.selectorLabels" . | nindent 4 }}
app.kubernetes.io/component: file-server
Expand Down
1 change: 1 addition & 0 deletions charts/api7/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ dp_manager_service:
file_server_service:
type: ClusterIP
port: 8080
# nodePort: 30080
Comment thread
nic-chen marked this conversation as resolved.

developer_portal_service:
type: ClusterIP
Expand Down
Loading