Add method to change encoder encoding type.#29
Merged
leonardocavagnis merged 2 commits intoarduino-libraries:mainfrom Jul 22, 2025
jiander-snap:encoder_enhancement
Merged
Add method to change encoder encoding type.#29leonardocavagnis merged 2 commits intoarduino-libraries:mainfrom jiander-snap:encoder_enhancement
leonardocavagnis merged 2 commits intoarduino-libraries:mainfrom
jiander-snap:encoder_enhancement
Conversation
|
|
|
Memory usage change @ 21b2ff5
Click for full report table
Click for full report CSV |
per1234
added
type: enhancement
leonardocavagnis
requested changes
Jul 22, 2025
Contributor
leonardocavagnis
left a comment
leonardocavagnis
left a comment
There was a problem hiding this comment.
Thanks for contribution!
Minor change request
|
Memory usage change @ ddb326d
Click for full report table
Click for full report CSV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MachineControl_Encoders class defaults to X2 encoding and provides no way to change to X1 or X4. This change implements the setEncoding() to support changing the encoding type.