UPSTREAM PR #26911: Chunk oversized JSON string writes in JsonToBinaryStream#143
Open
UPSTREAM PR #26911: Chunk oversized JSON string writes in JsonToBinaryStream#143
Conversation
|
No meaningful performance changes were detected across 10167 analyzed functions in the following binaries: build.protoc-stable. 💬 Questions? Tag @loci-dev |
loci-dev
force-pushed
the
main
branch
5 times, most recently
from
2b89f87 to
2f65a6e
Compare
|
The analysis encountered an error. Please review the Processing Details for more information. |
loci-dev
force-pushed
the
main
branch
4 times, most recently
from
d240c24 to
2896021
Compare
loci-dev
force-pushed
the
main
branch
13 times, most recently
from
1f11459 to
0b4c478
Compare
loci-dev
force-pushed
the
main
branch
6 times, most recently
from
572a288 to
d3dd64f
Compare
|
No meaningful performance changes were detected across 10160 analyzed functions in the following binaries: build.protoc-stable. 💬 Questions? Tag @loci-dev |
loci-dev
force-pushed
the
main
branch
11 times, most recently
from
75c1917 to
ec8c960
Compare
|
No meaningful performance changes were detected across 10160 analyzed functions in the following binaries: build.protoc-stable. 💬 Questions? Tag @loci-dev |
loci-dev
force-pushed
the
main
branch
7 times, most recently
from
f292971 to
1fdfb93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: protocolbuffers/protobuf#26911
This change avoids oversized raw writes in the proto3 JSON-to-binary streaming path.
Changes:
ParseProto3Type::SetString()instead of passing asize_tlength directly intoWriteRaw(const void*, int)INT_MAX + 1boundary