Conversation
loci-dev
force-pushed
the
main
branch
30 times, most recently
from
cac2d55 to
558f1f4
Compare
loci-dev
force-pushed
the
main
branch
15 times, most recently
from
847b67c to
75c1917
Compare
Compute the absolute limit in long arithmetic so overflow no longer leaves state.currentLimit negative. Fixes #26856
loci-dev
force-pushed
the
loci/pr-26914-fix-csharp-readrawbyte-ioob-truncated-message
branch
from
8fcb410 to
355e425
Compare
|
No meaningful performance changes were detected across 10164 analyzed functions in the following binaries: build.protoc-stable. 💬 Questions? Tag @loci-dev |
loci-dev
force-pushed
the
main
branch
8 times, most recently
from
f292971 to
1fdfb93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: protocolbuffers/protobuf#26914
Summary
A near-int.MaxValue length varint overflows PushLimit, corrupting bufferSize to a negative value. ReadRawByte's == guard then never triggers RefillBuffer, causing an out-of-bounds read instead of InvalidProtocolBufferException.TruncatedMessage().
Fix
change == to >= in ReadRawByte. Regression tests added for all four affected slow-path variants.
Tests
Added
TruncatedMessageWithLargeInnerLengthThrowsInvalidProtocolBufferExceptionwith 4 test cases.Fixes #26856