Conversation
Co-authored-by: abear <abear@berachain.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2834 +/- ##
==========================================
- Coverage 60.82% 60.70% -0.12%
==========================================
Files 353 354 +1
Lines 16615 16647 +32
==========================================
Hits 10106 10106
- Misses 5722 5752 +30
- Partials 787 789 +2
🚀 New features to boost your workflow:
|
rezzmah
reviewed
Jul 1, 2025
Contributor
rezzmah
left a comment
There was a problem hiding this comment.
Code looks good but there may be another issue around the withdrawal credentials for Smilee not allowing for withdrawals since receive() is not triggered.
https://berascan.com/address/0x333bd3beb65f965eea04999ba3c0349a596e9ffe#code
Waiting for confirmation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See proposal in https://forum.berachain.com/t/validator-removal-from-active-set-to-account-for-new-bectra-withdrawal-functionality/205