Skip to content

Smilee fix on mainnet at electra1 fork#2834

Merged
abi87 merged 13 commits intomainfrom
smilee-fix
Aug 7, 2025
Merged

Smilee fix on mainnet at electra1 fork#2834
abi87 merged 13 commits intomainfrom
smilee-fix

Conversation

@abi87
Copy link
Copy Markdown
Contributor

@abi87 abi87 commented Jun 27, 2025

fridrik01 and others added 2 commits June 27, 2025 16:09
@abi87 abi87 self-assigned this Jun 27, 2025
@abi87 abi87 marked this pull request as ready for review June 27, 2025 14:15
@abi87 abi87 requested a review from a team as a code owner June 27, 2025 14:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 27, 2025

Codecov Report

❌ Patch coverage is 12.50000% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.70%. Comparing base (f018d0a) to head (df87870).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
state-transition/core/state_processor_fixes.go 13.79% 25 Missing ⚠️
state-transition/core/state_processor_forks.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2834      +/-   ##
==========================================
- Coverage   60.82%   60.70%   -0.12%     
==========================================
  Files         353      354       +1     
  Lines       16615    16647      +32     
==========================================
  Hits        10106    10106              
- Misses       5722     5752      +30     
- Partials      787      789       +2     
Files with missing lines Coverage Δ
state-transition/core/state_processor_forks.go 82.94% <0.00%> (-1.49%) ⬇️
state-transition/core/state_processor_fixes.go 13.79% <13.79%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@calbera calbera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Copy Markdown
Contributor

@rezzmah rezzmah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but there may be another issue around the withdrawal credentials for Smilee not allowing for withdrawals since receive() is not triggered.

https://berascan.com/address/0x333bd3beb65f965eea04999ba3c0349a596e9ffe#code

Waiting for confirmation

Copy link
Copy Markdown
Contributor

@rezzmah rezzmah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smilee confirmed allg

@abi87 abi87 merged commit 50dc1c6 into main Aug 7, 2025
21 checks passed
@abi87 abi87 deleted the smilee-fix branch August 7, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants