feat(node-api): Create proof endpoint for validator balance#2840
Merged
feat(node-api): Create proof endpoint for validator balance#2840
Conversation
Co-authored-by: calbera <calbera@berachain.com>
calbera
changed the title
calbera
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2840 +/- ##
==========================================
- Coverage 60.64% 60.53% -0.11%
==========================================
Files 354 356 +2
Lines 16673 16824 +151
==========================================
+ Hits 10111 10185 +74
- Misses 5773 5841 +68
- Partials 789 798 +9
🚀 New features to boost your workflow:
|
calbera
commented
Jul 8, 2025
Comment on lines
+81
to
+98
| bs := mock.NewBeaconStateWith( | ||
| tc.slot, vals, 0, common.ExecutionAddress{}, tc.forkVersion, | ||
| ) | ||
|
|
||
| bs.Balances = make([]uint64, tc.numValidators) | ||
| bs.Balances[tc.valIndex] = tc.balance | ||
|
|
||
| bbh := ctypes.NewBeaconBlockHeader( | ||
| tc.slot, | ||
| tc.valIndex, | ||
| tc.parentBlockRoot, | ||
| bs.HashTreeRoot(), | ||
| tc.bodyRoot, | ||
| ) | ||
|
|
||
| proof, _, _, err := merkle.ProveBalanceInBlock(tc.valIndex, bbh, bs, bs.Balances) | ||
| require.NoError(t, err) | ||
| expectedProof := ReadProofFromFile(t, tc.expectedProofFile) |
Contributor
Author
There was a problem hiding this comment.
@bearmigiano you can use this code to re-create the balance proofs for specific data as needed in contracts testing
calbera
commented
Jul 8, 2025
|
|
||
| // BalanceLeaf is the leaf containing the validator's balance along with up | ||
| // to 3 other validators' balances (packed 4 per leaf). | ||
| BalanceLeaf common.Root `json:"balance_leaf"` |
Contributor
Author
There was a problem hiding this comment.
@bearmigiano important to note for staking pools: The leaf of the proof is not just the HashTreeRoot of the balance. Since the leaf contains multiple balances (not just the one we are proving), you must use this one while verifying the proof.
calbera
commented
Jul 11, 2025
calbera
commented
Jul 11, 2025
Signed-off-by: Cal Bera <calbera@berachain.com>
Signed-off-by: Cal Bera <calbera@berachain.com>
abi87
reviewed
Jul 14, 2025
Comment on lines
+40
to
+43
| type ValidatorBalanceRequest struct { | ||
| types.TimestampIDRequest | ||
| ValidatorIndex string `param:"validator_index" validate:"required,numeric"` | ||
| } |
Contributor
There was a problem hiding this comment.
This seems identical to ValidatorCredentialsRequest. Can we use a type alias instead of duplicating the requests?
…eate-node-api-endpoint-for-validator-balance-d97e
calbera
deleted the
cursor/create-node-api-endpoint-for-validator-balance-d97e
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a node-api endpoint to provide Merkle proofs for a validator's balance at a specific timestamp.