Skip to content

feat(js_analyze): implement noJsxLeakedComment#9914

Draft
Netail wants to merge 2 commits intobiomejs:mainfrom
Netail:feat/no-jsx-leaked-comment
Draft

feat(js_analyze): implement noJsxLeakedComment#9914
Netail wants to merge 2 commits intobiomejs:mainfrom
Netail:feat/no-jsx-leaked-comment

Conversation

@Netail
Copy link
Copy Markdown
Member

@Netail Netail commented Apr 11, 2026

Summary

Port https://www.eslint-react.xyz/docs/rules/jsx-no-comment-textnodes, which disallows comment syntax in JSX text nodes.

Partially generated by co-pilot

Test Plan

Unit tests

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 11, 2026

🦋 Changeset detected

Latest commit: 3557864

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Apr 11, 2026
@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project labels Apr 11, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 11, 2026

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 196 skipped benchmarks1


Comparing Netail:feat/no-jsx-leaked-comment (3557864) with main (e7775a5)

Open in CodSpeed

Footnotes

  1. 196 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant