Mach-O: Set LC_BUILD_VERSION#13131
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Apr 20, 2026
Merged
Conversation
Member
|
@bjorn3 would you be willing to review? |
github-actions
Bot
added
cranelift
Contributor
|
Looks fine to me, but CI fails. |
madsmtm
force-pushed
the
macho-build-version
branch
from
67ebe3c to
651ea9e
Compare
madsmtm
force-pushed
the
macho-build-version
branch
from
651ea9e to
8445b7c
Compare
Contributor
Author
|
Had to update the |
This comment was marked as resolved.
This comment was marked as resolved.
This makes the linker stop warning about missing platform load command.
madsmtm
force-pushed
the
macho-build-version
branch
from
8445b7c to
e333f30
Compare
bjorn3
approved these changes
Apr 19, 2026
alexcrichton
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8730, the remaining linker warnings are now gone.
See also rust-lang/rustc_codegen_cranelift#1645 which passes the actual version (instead of just specifying
0.0.0).