refactor(sharddistributor): remove migration passthrough modes from executor client#7861
Open
eleonoradgr wants to merge 2 commits intocadence-workflow:masterfrom
Open
refactor(sharddistributor): remove migration passthrough modes from executor client#7861eleonoradgr wants to merge 2 commits intocadence-workflow:masterfrom
eleonoradgr wants to merge 2 commits intocadence-workflow:masterfrom
Conversation
Signed-off-by: edigregorio <edigregorio@uber.com>
Signed-off-by: edigregorio <edigregorio@uber.com>
Code Review ✅ ApprovedRemoves migration passthrough modes from the executor client, simplifying the shard distributor implementation. No issues found. Rules ✅ All requirements metRepository Rules
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Removed the
LOCAL_PASSTHROUGH_SHADOWandDISTRIBUTED_PASSTHROUGHmigration modes from the executor client, along with theAssignShardsFromLocalLogicandRemoveShardsFromLocalLogicinterface methods and their implementations. Also removed thecompareAssignments/emitMetricsConvergencehelpers and the associatedconvergence/divergence metrics. Relates to #6862.
Why?
These migration modes and the external-assignment methods were part of a non used migration path for onboarding namespaces to shard distributor. The
LOCAL_PASSTHROUGH_SHADOWandDISTRIBUTED_PASSTHROUGHmodes acted as intermediate steps that are no longer needed since we rely on fully onboarded mode and percentage base onboarding(ONBOARDEDmode).Keeping dead code around increases cognitive load and leaves error-prone paths.
How did you test it?
make pr GEN_DIR=service/sharddistributor/client/executorclient
Package unit tests (race detector enabled)
go test -race -count=1 ./service/sharddistributor/client/executorclient/...
Result: ok github.com/uber/cadence/service/sharddistributor/client/executorclient 3.714s
Full build check
make build
Potential risks
None — the removed methods were only called from code already cleaned up in prior PRs. No API/IDL, schema, or feature flag changes.
Release notes
N/A — internal change.
Documentation Changes
N/A