Skip to content

refactor(sharddistributor): remove migration passthrough modes from executor client#7861

Open
eleonoradgr wants to merge 2 commits intocadence-workflow:masterfrom
eleonoradgr:cleanup-executor-clients
Open

refactor(sharddistributor): remove migration passthrough modes from executor client#7861
eleonoradgr wants to merge 2 commits intocadence-workflow:masterfrom
eleonoradgr:cleanup-executor-clients

Conversation

@eleonoradgr
Copy link
Copy Markdown
Contributor

@eleonoradgr eleonoradgr commented Mar 31, 2026

What changed?
Removed the LOCAL_PASSTHROUGH_SHADOW and DISTRIBUTED_PASSTHROUGH migration modes from the executor client, along with the AssignShardsFromLocalLogic and
RemoveShardsFromLocalLogic interface methods and their implementations. Also removed the compareAssignments/emitMetricsConvergence helpers and the associated
convergence/divergence metrics. Relates to #6862.

Why?
These migration modes and the external-assignment methods were part of a non used migration path for onboarding namespaces to shard distributor. The
LOCAL_PASSTHROUGH_SHADOW and DISTRIBUTED_PASSTHROUGH modes acted as intermediate steps that are no longer needed since we rely on fully onboarded mode and percentage base onboarding(ONBOARDED mode).
Keeping dead code around increases cognitive load and leaves error-prone paths.

How did you test it?
make pr GEN_DIR=service/sharddistributor/client/executorclient

Package unit tests (race detector enabled)

go test -race -count=1 ./service/sharddistributor/client/executorclient/...
Result: ok github.com/uber/cadence/service/sharddistributor/client/executorclient 3.714s

Full build check

make build

Potential risks
None — the removed methods were only called from code already cleaned up in prior PRs. No API/IDL, schema, or feature flag changes.

Release notes
N/A — internal change.

Documentation Changes
N/A

Signed-off-by: edigregorio <edigregorio@uber.com>
Signed-off-by: edigregorio <edigregorio@uber.com>
@eleonoradgr eleonoradgr changed the title Cleanup executor clients refactor(sharddistributor): remove migration passthrough modes from executor client Mar 31, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot bot commented Mar 31, 2026

Code Review ✅ Approved

Removes migration passthrough modes from the executor client, simplifying the shard distributor implementation. No issues found.

Rules ✅ All requirements met

Repository Rules

No CI failures detected: No CI failures were detected in the PR.
PR has description and tests: PR includes a detailed description of what changed, why, and how it was tested including unit tests and build checks.
Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant