Open
Conversation
2 tasks
|
🚀 Preview URL for this PR: https://04540253-civic-dashboard-web.civic-dashboard.workers.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #303
Adds a geographic map to the actions page showing the locations of agenda items when geographic data is available in the database. The map also has a "search this area" feature where the items shown in the results list below can be filtered to be those in the current map in addition to those items which do not have a geographic location associated to them.
Before:

After:

I'm unsure about styling of the map, which is all done in AgendaItemList.tsx. Specifically, I have the map at a fixed 350px height right now, but I can imagine that might not work for all devices, so some direction there would be nice.
Testing instructions
The map should show all of the items currently shown in the results list which have geographic data. If more items are loaded or if filters are applied, the map should update accordingly. The "search this area" button should appear at the top of the map when the map is moved/zoomed, and if clicked should update the items shown in the results list below - if anywhere else on the map is clicked the button should disappear. Additionally, the button should reappear if the map has been moved/zoomed again.
Checklist