Exit peacefully on KeyboardInterrupt by jackthepirate6 · Pull Request #214 · coala/coala-quickstart

jackthepirate6 · 2018-02-02T05:51:13Z

Captured keyboardinterrupt without traceback.

Closes issue #179

khanchi97 · 2018-02-02T20:49:38Z

    return arg_parser


+def signal_handler(signal, frame):


What is the need of passing arguments to this function if you are not using them?

I get the following error if i don't pass the arguments,
TypeError: signal_handler() takes 0 positional arguments but 2 were given

@jackthepirate6 thats probably because you are forgetting self or cls. You need to remove those unnecessary arguments.

khanchi97 · 2018-02-02T20:53:37Z

And in commit description:
Use Closes link_to_the_issue instead of using Closes issue link_to_the_issue.

newbazz · 2018-02-03T08:54:37Z

 import logging
 import os
 import sys
+import signal


this import will be above import sys following alphabetical order ;)

newbazz · 2018-02-03T08:55:22Z

+def signal_handler(self, cls):
+    sys.exit(0)
+
+


no need of two blank lines.

According to E302 of pep8, there should be two blank lines instead of one

the newlines are fine

although I didn't mean for you to add both self and cls

both are actually the same, with different names

It is difficult to know when a person will system exit.

So it's kind of better to initialise exception handler first

hmmm... frankly speaking I don't understand what you are trying to do over here 🤪 but adding those two parameters without knowing why its working that way is definitely wrong

i am trying to capture the exception globally.

i will remove the unnecessary parameters.

Captured keyboardinterrupt without traceback. Closes coala#179

jayvdb

Please review your commit message to follow http://coala.io/commit , and capitalise exception names correctly.

gitmate-bot added process/pending review size/XS labels Feb 2, 2018

khanchi97 reviewed Feb 2, 2018

View reviewed changes

jackthepirate6 force-pushed the crane branch from 9e7d628 to 581004b Compare February 3, 2018 06:58

gitmate-bot added difficulty/low initiatives/gci status/STALE labels Feb 3, 2018

newbazz reviewed Feb 3, 2018

View reviewed changes

jackthepirate6 force-pushed the crane branch from 581004b to aa6d399 Compare February 3, 2018 10:56

Exit peacefully on KeyboardInterrupt

92f16d7

Captured keyboardinterrupt without traceback. Closes coala#179

jackthepirate6 force-pushed the crane branch from aa6d399 to 92f16d7 Compare February 4, 2018 09:08

jayvdb added process/wip and removed process/pending review labels Apr 25, 2018

jayvdb requested changes Apr 25, 2018

View reviewed changes

Conversation

jackthepirate6 commented Feb 2, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khanchi97 commented Feb 2, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jackthepirate6 Feb 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jayvdb left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

jackthepirate6 Feb 4, 2018 •

edited

Loading