Android: Fixes androidMainActivity to only run when there's no passed activity#6992
Merged
lefou merged 4 commits intocom-lihaoyi:mainfrom Apr 17, 2026
Merged
Conversation
vaslabs
changed the title
Contributor
Author
|
This is ready |
Contributor
Author
|
on the Jetcaster tv, it wasn't discovering the main activity automatically because the launcher is different -> |
Contributor
Author
lefou
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue introduced in #6980
Runs the androidMainActivity only if it's not passed as an argument, avoiding the non-existing error
cc: @souvlakias
Verification: https://github.com/vaslabs-ltd/compose-samples-with-mill/actions/runs/24177395330 and https://github.com/vaslabs-ltd/compose-samples-with-mill/actions/runs/24390871608
Also fixes the auto-detection of Android TV android activities