Skip to content

fix: line number anchor in source links#1182

Open
gennaroprota wants to merge 1 commit intocppalliance:developfrom
gennaroprota:fix/line_number_anchor_in_source_links
Open

fix: line number anchor in source links#1182
gennaroprota wants to merge 1 commit intocppalliance:developfrom
gennaroprota:fix/line_number_anchor_in_source_links

Conversation

@gennaroprota
Copy link
Copy Markdown
Collaborator

@gennaroprota gennaroprota commented Apr 23, 2026

The source link in the Synopsis section of each symbol page contained #Lundefined anchors. That's because the corresponding Handlebars template used the wrong field name (dcl.line instead of dcl.lineNumber).

Note that the separate concern of these links pointing at a moving branch rather than at a permalink for the documented commit is tracked in #1034.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

✨ Highlights

  • 🧪 New golden tests added

🧾 Changes by Scope

Scope Lines Δ% Lines Δ Lines + Lines - Files Δ Files + Files ~ Files ↔ Files -
🥇 Golden Tests 98% 121 121 - 5 5 - - -
🛠️ Source 2% 2 1 1 1 - 1 - -
Total 100% 123 122 1 6 5 1 - -

Legend: Files + (added), Files ~ (modified), Files ↔ (renamed), Files - (removed)

🔝 Top Files

  • test-files/golden-tests/config/base-url/base-url.html (Golden Tests): 49 lines Δ (+49 / -0)
  • test-files/golden-tests/config/base-url/base-url.xml (Golden Tests): 36 lines Δ (+36 / -0)
  • test-files/golden-tests/config/base-url/base-url.adoc (Golden Tests): 29 lines Δ (+29 / -0)

Generated by 🚫 dangerJS against 088ff29

@gennaroprota gennaroprota force-pushed the fix/line_number_anchor_in_source_links branch from 7a5593e to fca5ca0 Compare April 23, 2026 06:26
@cppalliance-bot
Copy link
Copy Markdown

cppalliance-bot commented Apr 23, 2026

An automated preview of the documentation is available at https://1182.mrdocs.prtest2.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-05-06 13:44:00 UTC

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.12%. Comparing base (8556f23) to head (088ff29).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1182   +/-   ##
========================================
  Coverage    82.12%   82.12%           
========================================
  Files           33       33           
  Lines         3149     3149           
  Branches       734      734           
========================================
  Hits          2586     2586           
  Misses         387      387           
  Partials       176      176           
Flag Coverage Δ
bootstrap 82.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gennaroprota gennaroprota force-pushed the fix/line_number_anchor_in_source_links branch 3 times, most recently from dd39666 to e87570a Compare April 30, 2026 13:58
@gennaroprota gennaroprota force-pushed the fix/line_number_anchor_in_source_links branch from e87570a to 64d2cfe Compare May 4, 2026 09:10
The source link in the Synopsis section of each symbol page contained
`#Lundefined` anchors. That's because the corresponding Handlebars
template used the wrong field name (`dcl.line` instead of
`dcl.lineNumber`).

Note that the separate concern of these links pointing at a moving
branch rather than at a permalink for the documented commit is tracked
in cppalliance#1034.
@gennaroprota gennaroprota force-pushed the fix/line_number_anchor_in_source_links branch from 64d2cfe to 088ff29 Compare May 6, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants