Skip to content

css refactor: components/_social#5259

Open
Bargraph6 wants to merge 3 commits intocrimethinc:mainfrom
Bargraph6:css-refactor-components-social
Open

css refactor: components/_social#5259
Bargraph6 wants to merge 3 commits intocrimethinc:mainfrom
Bargraph6:css-refactor-components-social

Conversation

@Bargraph6
Copy link
Copy Markdown
Contributor

@Bargraph6 Bargraph6 commented Apr 14, 2026

What are the relevant GitHub issues?

related to this PR: #5212

What does this pull request do?

This PR:

  1. renames _socials.scss to _socials.css
  2. updates the social icons to use css variables instead of scss variables
  3. adds a .visually-hidden css class to use in place of the current text-indent: -10000%; approach

How should this be manually tested?

I loaded up the home page and articles page to see the social links:

before after
home before-home after-home
article before-article after-article

Questions for the pull request author (delete any that don't apply):

  • Are any needed README/wiki/documentation updates needed for this pull request?
  • Does the code you updated have tests? If not, could you add some please?
  • Does this pull request require any new server dependencies which need to be added to the build process? If so, please explain what.

Acceptance Criteria

These should be checked by the reviewers

  • This pull request does not cause the database export script to become out of sync with the db schema

@Bargraph6 Bargraph6 marked this pull request as ready for review April 14, 2026 14:07
@Bargraph6 Bargraph6 changed the title Css refactor components social css refactor: components/_social Apr 14, 2026
@Bargraph6
Copy link
Copy Markdown
Contributor Author

@veganstraightedge @just1602 this is ready for review

@@ -0,0 +1,42 @@
.social {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the github UI, if you look at the individual commit diffs, rather than the "all commits" view, you will get a more helpful diff:

f60514c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant