rewrite memory module to use GDB's "x" output#306
Open
nwlyoc wants to merge 5 commits intocyrus-and:masterfrom
Open
rewrite memory module to use GDB's "x" output#306nwlyoc wants to merge 5 commits intocyrus-and:masterfrom
nwlyoc wants to merge 5 commits intocyrus-and:masterfrom
Conversation
This is a rewrite of the memory module to enable watching a memory region with the format options of GDB's "x" command. Instead of getting a raw memory dump like before, an "x" command is created, evaluated by GDB and its output is formatted according to the dashboard settings. The watch command of the previous memory module can be used and extended for backwards compatibility. Alternatively the watch command also accepts an "x" command as it would be entered into GDB directly.
Instructions and strings have variable sizes, so the addresses for consecutive objects can't be calculated. To fix this, display only one object per line when the format is "i" or "s" (like in GDB's x output) and keep the addresses from GDB's output. This also has the benefit of displaying address tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed a convenient way to constantly watch a memory region with the format options of GDB's "x" command (e. g. watching not only single bytes). This is a rewrite of the memory module to achieve this.
Instead of getting a raw memory dump like before, an "x" command is created, evaluated by GDB and its output is formatted according to the dashboard settings. The watch command of the previous memory module can be used and extended for backwards compatibility. Alternatively the watch command also accepts an "x" command as it would be entered into GDB directly.
I understand that this might not be a wanted feature to integrate as discussed in #21, but I find this very useful and wanted to leave this here for anyone interested even if it won't be integrated.
edit/added screenshot:
