Use typescript strict mode

Author: darkriszty

cli/argumentsParser.ts

@@ -10,7 +10,7 @@ export function parseArguments(processArgs: string[]): CliOptions {
         return processArgs.length > 2 && processArgs.find(arg => arg.startsWith("--" + key)) !== undefined;
     }
 
-    function getArgumentValue(key: string): string {
+    function getArgumentValue(key: string): string | null {
         const hasArguments = processArgs.length > 2;
         const split = (hasArguments
             ? processArgs.find(arg => arg.startsWith("--" + key)) || ""

src/modelFactory/tableIndentationDetector.ts

@@ -3,7 +3,7 @@ export abstract class TableIndentationDetector {
     protected abstract getIndentationChars(leftPadsPerLine: string[]): string;
 
     public getLeftPad(lines: string[]): string {
-        const leftPadsPerLine: string[] = lines.map(l => l.match(/^\s*/)[0]);
+        const leftPadsPerLine: string[] = lines.map(l => (l.match(/^\s*/) || [""])[0]);
 
         return this.hasIndentation(leftPadsPerLine)
             ? this.getIndentationChars(leftPadsPerLine)

src/modelFactory/transformers/transformer.ts

@@ -2,7 +2,7 @@ import { Table } from "../../models/table";
 
 export abstract class Transformer {
 
-    constructor (private _next: Transformer) { }
+    constructor (private _next: Transformer | null) { }
 
     protected abstract transform(input: Table): Table;
 

src/models/doc/document.ts

@@ -16,13 +16,13 @@ export class Document {
         return new Range(0, this._lines.length);
     }
 
-    public getLines(range: Range): Line[] {
+    public getLines(range: Range | null): Line[] {
         return range == null
             ? this.lines
             : this.lines.slice(range.startLine, range.endLine + 1);
     }
 
-    public getText(range: Range = null): string {
+    public getText(range: Range | null = null): string {
         const lines = this.getLines(range);
 
         return lines.reduce((acc, curr, index) => {

src/models/table.ts

@@ -3,7 +3,7 @@ import { Row } from "./row";
 
 export class Table {
     private readonly _rows: Row[];
-    private _longestColumnLengthsCache: number[] = null;
+    private _longestColumnLengthsCache: number[] | null = null;
 
     constructor(
         rows: Row[],

src/prettyfiers/multiTablePrettyfier.ts

@@ -18,7 +18,7 @@ export class MultiTablePrettyfier {
         }
 
         let document = new Document(input);
-        let tableRange: Range = null;
+        let tableRange: Range | null = null;
         let tableSearchStartLine = 0;
 
         while ((tableRange = this._tableFinder.getNextRange(document, tableSearchStartLine)) != null) {

src/prettyfiers/singleTablePrettyfier.ts

@@ -22,7 +22,7 @@ export class SingleTablePrettyfier {
 
     public prettifyTable(document: Document, range: Range) : string
     {
-        let result: string = null;
+        let result: string | null = null;
         let message: string = "";
         const selection: string = document.getText(range);
 
@@ -44,6 +44,6 @@ export class SingleTablePrettyfier {
         if (!!message)
             this._loggers.forEach(_ => _.logInfo(message));
 
-        return result;
+        return result!;
     }
 }

src/tableFinding/tableFinder.ts

@@ -10,7 +10,7 @@ export class TableFinder {
         private readonly _tableValidator: TableValidator
     ) { }
 
-    public getNextRange(document: Document, startLine: number): Range {
+    public getNextRange(document: Document, startLine: number): Range | null {
         // look for the separator row, assume table starts 1 row before & ends when invalid
         let rowIndex = startLine;
         let isInIgnoreBlock = false;
@@ -24,7 +24,7 @@ export class TableFinder {
 
             if (!isInIgnoreBlock) {
                 const isValidSeparatorRow = this._tableValidator.lineIsValidSeparator(document.lines[rowIndex].value);
-                const nextRangeResult: { range: Range, ignoreBlockStarted: boolean } = isValidSeparatorRow
+                const nextRangeResult: { range: Range | null, ignoreBlockStarted: boolean } = isValidSeparatorRow
                     ? this.getNextValidTableRange(document, rowIndex)
                     : { range: null, ignoreBlockStarted: isInIgnoreBlock};
 
@@ -40,7 +40,7 @@ export class TableFinder {
         return null;
     }
 
-    private getNextValidTableRange(document: Document, separatorRowIndex: number): { range: Range, ignoreBlockStarted: boolean} {
+    private getNextValidTableRange(document: Document, separatorRowIndex: number): { range: Range | null, ignoreBlockStarted: boolean} {
         let firstTableFileRow = separatorRowIndex - 1;
         let lastTableFileRow = separatorRowIndex;
         let selection = null;

src/viewModels/tableViewModel.ts

@@ -5,9 +5,9 @@ export class TableViewModel {
     public get rowCount(): number { return this.rows.length; }
 
     public leftPad: string = "";
-    public header: RowViewModel;
-    public separator: RowViewModel;
+    public header!: RowViewModel;
+    public separator!: RowViewModel;
     public rows: RowViewModel[] = [];
-    public hasLeftBorder: boolean;
-    public hasRightBorder: boolean;
+    public hasLeftBorder!: boolean;
+    public hasRightBorder!: boolean;
 }

test/stubs/markdownTextDocumentStub.ts

@@ -3,16 +3,16 @@ import { EOL } from "os";
 import { TextLineStub } from "./textLineStub";
 
 export class MarkdownTextDocumentStub implements vscode.TextDocument {
-    private _lines: string[];
-    uri: vscode.Uri;
+    private _lines!: string[];
+    uri!: vscode.Uri;
     fileName: string;
     isUntitled: boolean;
     languageId: string;
     version: number;
     isDirty: boolean;
-    lineCount: number;
-    isClosed: boolean;
-    eol: vscode.EndOfLine;
+    lineCount!: number;
+    isClosed!: boolean;
+    eol!: vscode.EndOfLine;
     encoding: string;
 
     constructor(text: string) {