Merge pull request #2562 from dolthub/nathan/paramChanges

Support using same parameter multiple times

Author: NathanGabrielson

server/connection_data.go

@@ -30,6 +30,7 @@ import (
 	"github.com/dolthub/doltgresql/core/dataloader"
 	"github.com/dolthub/doltgresql/core/id"
 	pgexprs "github.com/dolthub/doltgresql/server/expression"
+	"github.com/dolthub/doltgresql/server/functions/framework"
 	"github.com/dolthub/doltgresql/server/node"
 	pgtypes "github.com/dolthub/doltgresql/server/types"
 )
@@ -147,9 +148,8 @@ func extractBindVarTypes(queryPlan sql.Node) ([]uint32, error) {
 					return false
 				}
 			}
-			if _, ok := types[e.Name]; ok {
-				// sanity check
-				err = errors.Errorf("double placeholder given for %s", e.Name)
+			if existingOid, ok := types[e.Name]; ok {
+				err = checkCompatibleTypes(existingOid, typOid, e.Name)
 			}
 			types[e.Name] = typOid
 		case *pgexprs.ExplicitCast:
@@ -164,9 +164,8 @@ func extractBindVarTypes(queryPlan sql.Node) ([]uint32, error) {
 						return false
 					}
 				}
-				if _, ok = types[bindVar.Name]; ok {
-					// sanity check
-					err = errors.Errorf("double placeholder given for %s", bindVar.Name)
+				if existingOid, ok := types[bindVar.Name]; ok {
+					err = checkCompatibleTypes(existingOid, typOid, bindVar.Name)
 				}
 				types[bindVar.Name] = typOid
 				return false
@@ -180,9 +179,8 @@ func extractBindVarTypes(queryPlan sql.Node) ([]uint32, error) {
 					err = errors.Errorf("could not determine OID for placeholder %s: %e", bindVar.Name, err)
 					return false
 				}
-				if _, ok = types[bindVar.Name]; ok {
-					// sanity check
-					err = errors.Errorf("double placeholder given for %s", bindVar.Name)
+				if existingOid, ok := types[bindVar.Name]; ok {
+					err = checkCompatibleTypes(existingOid, typOid, bindVar.Name)
 				}
 				types[bindVar.Name] = typOid
 				return false
@@ -225,3 +223,14 @@ func VitessTypeToObjectID(typ sql.Type) (uint32, error) {
 	}
 	return id.Cache().ToOID(doltgresType.ID.AsId()), nil
 }
+
+// checkCompatibleTypes checks if multiple types for which a parameter are used are compatible.
+func checkCompatibleTypes(existingOid, newOid uint32, newName string) error {
+	var err error
+	existing := pgtypes.GetTypeByID(id.Type(id.Cache().ToInternal(existingOid)))
+	newType := pgtypes.GetTypeByID(id.Type(id.Cache().ToInternal(newOid)))
+	if _, _, err = framework.FindCommonType([]*pgtypes.DoltgresType{existing, newType}); err != nil {
+		err = errors.Errorf("parameter %s is used for incompatible types: %s and %s", newName, existing.String(), newType.String())
+	}
+	return err
+}

testing/go/prepared_statement_test.go

@@ -1294,6 +1294,59 @@ var preparedStatementTests = []ScriptTest{
 			},
 		},
 	},
+	{
+		Name: "Bind parameter to compatible different types",
+		SetUpScript: []string{
+			"CREATE TABLE text_test (id text, code varchar(10))",
+			"CREATE TABLE num_test(small int2, large int8, other float4)",
+			"INSERT INTO text_test values ('foo', 'bar'), ('bar', 'foo')",
+			"INSERT INTO num_test values (0,0,0), (1, 2, 1.5)",
+		},
+		Assertions: []ScriptTestAssertion{
+			{
+				Query:    "SELECT * FROM text_test where id = any($1) and code = any($1)",
+				BindVars: []any{[]string{"foo", "bar"}},
+				Expected: []sql.Row{
+					{"foo", "bar"},
+					{"bar", "foo"},
+				},
+			},
+			{
+				Query:    "SELECT * from num_test where small = $1 and large = $1 and other = $1",
+				BindVars: []any{0},
+				Expected: []sql.Row{
+					{0, 0, float64(0)},
+				},
+			},
+			{
+				Query:    "SELECT * from num_test where small = $1::INTEGER and large = $1::INTEGER and other = $1::INTEGER",
+				BindVars: []any{0},
+				Expected: []sql.Row{
+					{0, 0, float64(0)},
+				},
+			},
+			{
+				Query:    "SELECT * FROM num_test where small = $1 or other = $1",
+				BindVars: []any{1.5},
+				Expected: []sql.Row{
+					{1, 2, 1.5},
+				},
+			},
+		},
+	},
+	{
+		Name: "Cannot bind parameter to column with incompatible type",
+		SetUpScript: []string{
+			"CREATE TABLE text_test (fullname text, id int)",
+		},
+		Assertions: []ScriptTestAssertion{
+			{
+				Query:       "SELECT * FROM text_test where fullname = $1 and id = $1",
+				BindVars:    []any{1},
+				ExpectedErr: "parameter v1 is used for incompatible types: text and integer",
+			},
+		},
+	},
 }
 
 var pgCatalogTests = []ScriptTest{