Revert path filters on required checks#1342
Merged
BillWagner merged 2 commits intodraft-v8from Jun 13, 2025
Merged
Conversation
Member
|
@jnm2 Yes, that's correct. I've run into that before on other repos in the dotnet org. If a check is required. It must run and complete with a successful exit code. If it doesn't run because of a filter, that's considered "not completed", and therefore blocks merging. A way to keep these reasonably efficient is to use the shell script to quickly exit (successfully) if nothing needs to be done. It's a balance to determine how much work is done to determine how much more work to do.... And, since the container has already been allocated and started, the savings may not be worth the effort and maintainence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three of the four workflows which gained new path filters in #1336 are required checks. It appears that if a workflow is a required check, GitHub will not allow that check to be satisfied when the workflow's filter tells it not to be triggered: