Skip to content

Revert path filters on required checks#1342

Merged
BillWagner merged 2 commits intodraft-v8from
jnm2/revert_path_filters_on_required_checks
Jun 13, 2025
Merged

Revert path filters on required checks#1342
BillWagner merged 2 commits intodraft-v8from
jnm2/revert_path_filters_on_required_checks

Conversation

@jnm2
Copy link
Copy Markdown
Contributor

@jnm2 jnm2 commented Jun 5, 2025

Three of the four workflows which gained new path filters in #1336 are required checks. It appears that if a workflow is a required check, GitHub will not allow that check to be satisfied when the workflow's filter tells it not to be triggered:

image

@BillWagner
Copy link
Copy Markdown
Member

@jnm2 Yes, that's correct. I've run into that before on other repos in the dotnet org. If a check is required. It must run and complete with a successful exit code. If it doesn't run because of a filter, that's considered "not completed", and therefore blocks merging.

A way to keep these reasonably efficient is to use the shell script to quickly exit (successfully) if nothing needs to be done. It's a balance to determine how much work is done to determine how much more work to do.... And, since the container has already been allocated and started, the savings may not be worth the effort and maintainence.

Copy link
Copy Markdown
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillWagner BillWagner merged commit 516c3b4 into draft-v8 Jun 13, 2025
4 checks passed
@jnm2 jnm2 deleted the jnm2/revert_path_filters_on_required_checks branch June 13, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants