Incorporate using_declaration#1632
Open
BillWagner wants to merge 4 commits intodotnet:draft-v8from
Open
Conversation
Fixes dotnet#1606. Add the using_declaration to the ANTLR grammar for *declaration_statement*, In addition, add a sentence in the clause that points to the correct clause for the declaration.
Nigel-Ecma
requested changes
Apr 26, 2026
Contributor
Nigel-Ecma
left a comment
Nigel-Ecma
left a comment
There was a problem hiding this comment.
The grammar is fine (I have suggested a cosmetic rule name change), and this is a good place to link this in.
Unfortunately the using declaration differs from the others wrt to declaration spaces so adding it requires more prose work. The existing text for using statements & declarations in §13.14 itself does not directly discuss declaration spaces, instead relying on the reader to deduce this detail from the semantic equivalent code – that choice should be reviewed in light of this PR.
BillWagner
added
the
meeting: discuss
§13.6.1 first sentence — added "or a local using scope" + switch_block carve-out. §13.6.1 declaration-space sentence — added "Except for a using_declaration, …" qualifier and the new-scope explanation. §13.14.2 — added the explicit declaration-space/scope sentence after the lifetime sentence. §13.14.2 — fixed switch_label → switch_block.
Change *using_declaration* to *local_using_declaration*
Respond to feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1606.
Add the using_declaration to the ANTLR grammar for declaration_statement, In addition, add a sentence in the clause that points to the correct clause for the declaration.