Skip to content

Convert Marshal test Variant usage to ComVariant#126968

Draft
Copilot wants to merge 1 commit intomainfrom
copilot/convert-to-comvariant-type
Draft

Convert Marshal test Variant usage to ComVariant#126968
Copilot wants to merge 1 commit intomainfrom
copilot/convert-to-comvariant-type

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 15, 2026

Note

This pull request description was generated with AI/Copilot assistance.

Summary

  • Replaced System.Runtime.InteropServices.Tests.Common.Variant usage in GetNativeVariantForObjectTests with ComVariant.
  • Updated variant assertions to use ComVariant.VarType and GetRawDataRef<T>().
  • Removed the now-obsolete test helper file Marshal/Common/Variant.cs and its project include.

Validation

  • Baseline build: ./build.sh clr+libs -rc release
  • dotnet build in src/libraries/System.Runtime.InteropServices
  • dotnet build /t:test for System.Runtime.InteropServices.Tests.csproj
  • parallel_validation run (Code Review + CodeQL)

Notes

  • Multi-model code review was run; one model flagged incomplete migration, but this was a false positive because the other Variant usages are separate test-local structs, and the build/tests pass.

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/b87f2dcb-ecea-4af2-b091-551b6de94281

Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 15, 2026 21:27
Copilot AI review requested due to automatic review settings April 15, 2026 21:27
Copilot AI requested a review from jkoritzinsky April 15, 2026 21:30
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants