feat: use component manager for icons#6499
Open
kenny-not-dead wants to merge 1 commit intodream-num:devfrom
Open
feat: use component manager for icons#6499kenny-not-dead wants to merge 1 commit intodream-num:devfrom
kenny-not-dead wants to merge 1 commit intodream-num:devfrom
Conversation
kenny-not-dead
requested review from
DR-Univer,
Dushusir,
Jocs,
VicKun4937,
jikkai,
weird94 and
wpxp123456
as code owners
View Deployment
|
kenny-not-dead
force-pushed
the
useComponentManagerForIcon
branch
2 times, most recently
from
009a2ff to
a85140e
Compare
kenny-not-dead
force-pushed
the
useComponentManagerForIcon
branch
from
a85140e to
b415a25
Compare
Contributor
Author
|
I returned ribbon type it because the tests for screenshots were failing, and I wanted to exclude the connection with icons. After returning the type to the default, the test passed. |
Contributor
Author
|
@jikkai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #xxx
I continued to use the component manager for icons, but the design package is mostly untouched now.
I temporarily installed a different type of ribbon type on the demo so you could make sure it works.
Pull Request Checklist