Skip to content

fix(sheets-ui): restore name box range naming flow#6705

Open
getmateri wants to merge 2 commits intodream-num:devfrom
getmateri:user-defined-named-cells-ranges-fix
Open

fix(sheets-ui): restore name box range naming flow#6705
getmateri wants to merge 2 commits intodream-num:devfrom
getmateri:user-defined-named-cells-ranges-fix

Conversation

@getmateri
Copy link
Copy Markdown
Contributor

Summary

  • allow the formula-bar name box to create workbook-scoped defined names from the current selection on Enter
  • reuse the defined-name validation rules in a shared helper so the name box and editor stay aligned
  • restore the normal non-editing sheet keyboard state after Enter so arrow-key navigation works immediately

Closes #6704

Test plan

  • pnpm vitest run src/views/defined-name/defined-name.utils.spec.ts
  • pnpm exec tsc -p tsconfig.json --noEmit
  • pnpm exec eslint packages/sheets-ui/src/views/defined-name/DefinedName.tsx packages/sheets-ui/src/views/defined-name/DefinedNameInput.tsx packages/sheets-ui/src/views/defined-name/defined-name.utils.ts packages/sheets-ui/src/views/defined-name/defined-name.utils.spec.ts
  • Manual test: create a named cell from the formula-bar name box and confirm arrow-key navigation works immediately after Enter
  • Manual test: create a named range from the formula-bar name box and confirm focus returns to the normal sheet state

Allow the formula-bar name box to create workbook-scoped names.
Return Enter to the normal spreadsheet navigation state.

Refs: dream-num#6704
@getmateri getmateri requested a review from jikkai as a code owner March 17, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] fix(sheets-ui): unlock sheet keyboard navigation after creating named ranges from name box

1 participant