fix(sheets-ui): restore name box range naming flow#6705
Open
getmateri wants to merge 2 commits intodream-num:devfrom
Open
fix(sheets-ui): restore name box range naming flow#6705getmateri wants to merge 2 commits intodream-num:devfrom
getmateri wants to merge 2 commits intodream-num:devfrom
Conversation
Allow the formula-bar name box to create workbook-scoped names. Return Enter to the normal spreadsheet navigation state. Refs: dream-num#6704
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6704
Test plan
pnpm vitest run src/views/defined-name/defined-name.utils.spec.tspnpm exec tsc -p tsconfig.json --noEmitpnpm exec eslint packages/sheets-ui/src/views/defined-name/DefinedName.tsx packages/sheets-ui/src/views/defined-name/DefinedNameInput.tsx packages/sheets-ui/src/views/defined-name/defined-name.utils.ts packages/sheets-ui/src/views/defined-name/defined-name.utils.spec.ts