Stamp dbt_spellbook provenance and explicit public/visible on spell properties#9593
Stamp dbt_spellbook provenance and explicit public/visible on spell properties#9593a-monteiro wants to merge 2 commits intomainfrom
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c8dcd23 to
fc0ff9b
Compare
…roperties Set dune.created_by=dbt_spellbook, dune.public, and dune.visible in the four shared property macros (mark_as_spell, expose_spells, hide_spells, expose_dataset) so that every spell lands with an explicit provenance tag and visibility state on the Dune catalog service. The baseline mark_as_spell applies to every model via the project-level post-hook; expose_spells/hide_spells/expose_dataset override as before. Also document the dbt Cloud and CI runner profile changes required for the catalog service migration, since they cannot be configured via this repo. Towards DWH-317
fc0ff9b to
1e637eb
Compare
PR SummaryMedium Risk Overview
Reviewed by Cursor Bugbot for commit 28f6a68. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed:
hide_spellsnow setsdune.publicto true- Reverted
dune.publicfrom'true'back to'false'in thehide_spellsmacro to restore the original access-restriction behavior.
- Reverted
Or push these changes by commenting:
@cursor push 992c547d46
Preview (992c547d46)
diff --git a/dbt_macros/dune/config_trino_properties.sql b/dbt_macros/dune/config_trino_properties.sql
--- a/dbt_macros/dune/config_trino_properties.sql
+++ b/dbt_macros/dune/config_trino_properties.sql
@@ -40,7 +40,7 @@
{%- if target.name == 'prod' -%}
{%- set properties = {
'dune.created_by': 'dbt_spellbook',
- 'dune.public': 'true',
+ 'dune.public': 'false',
'dune.visible': 'false',
'dune.data_explorer.category': 'abstraction',
'dune.vacuum': '{"enabled":true}'You can send follow-ups to the cloud agent here.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 28f6a68. Configure here.



Set dune.created_by=dbt_spellbook, dune.public, and dune.visible in the four shared property macros (mark_as_spell, expose_spells, hide_spells, expose_dataset) so that every spell lands with an explicit provenance tag and visibility state on the Dune catalog service. The baseline mark_as_spell applies to every model via the project-level post-hook; expose_spells/hide_spells/expose_dataset override as before.
Towards DWH-317