fix: prevent double icon render in promise toast (bug #718)#737
Open
AyushNigam-1 wants to merge 2 commits intoemilkowalski:mainfrom
Open
fix: prevent double icon render in promise toast (bug #718)#737AyushNigam-1 wants to merge 2 commits intoemilkowalski:mainfrom
AyushNigam-1 wants to merge 2 commits intoemilkowalski:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes bug #718 where toast.promise with a custom success icon renders both the loader and success icon.
The update ensures only the loader is shown during loading, and only the final icon is shown after resolve/reject.
Test
Added a Playwright test that reproduces the issue by using a custom SVG success icon and asserting only one SVG is rendered after resolution.
Notes
Some existing Playwright tests fail locally even on upstream code (auto-close callback + empty-id dismiss). These appear unrelated to this change.
The test uses an inline SVG to make the regression deterministic. Happy to adjust if a different approach is preferred.