[Repo Assist] refactor: simplify splitAt 'rest' taskSeq to use while!#393
Draft
github-actions[bot] wants to merge 2 commits intomainfrom
Draft
Conversation
The 'rest' sequence returned by splitAt used a manual go2 flag and an explicit MoveNextAsync pre-advance before its loop. This is equivalent to a direct 'while! e.MoveNextAsync() do yield e.Current' guarded by the existing 'go' flag (which tracks whether the source was exhausted while filling 'first'). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant.
Summary
The
restsequence produced byTaskSeq.splitAtused a manualgo2flag and an explicitMoveNextAsyncpre-advance before its inner loop:This is equivalent to a single
while! e.MoveNextAsync() doguarded by the existing outergoflag (which already tracks whether the source was exhausted while fillingfirst):This follows the same
while!idiom used throughout the codebase (e.g.tryTail,tryLast,lengthBy).Correctness
Three cases:
gocountfalserestis emptyrestis empty (guard skips)countelementstruefirst, yield remainderwhile!does the same advance-then-yieldcount = 0trueTest Status
dotnet build -c Release— succeeded (0 warnings, 0 errors)dotnet test -c Release— 5180 passed, 2 skipped (pre-existing infrastructure skips)dotnet fantomas . --check— passed