fix: get instructions from upstream guardian adapters#1037
Draft
psschwei wants to merge 4 commits intogenerative-computing:mainfrom
Draft
fix: get instructions from upstream guardian adapters#1037psschwei wants to merge 4 commits intogenerative-computing:mainfrom
psschwei wants to merge 4 commits intogenerative-computing:mainfrom
Conversation
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Member
Author
|
cc @pronics2004 |
Member
Author
|
Also note: there's updated |
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Member
Author
|
Latest commit uses pre-existing config file override |
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
b76390a to
b8d180d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
This is a test of a potential fix for #1017 . The goal is to move the instruction logic out of the guardian helper function and into the upstream
io.yamlfiles for each adapter/intrinsic.To see what that might look like, I've included a
mellea/backends/adapters/_overlays/directory with my take on what an updatedio.yamlfile might look like. These are temporary files to serve as a discussion point on what the final form might look like. This directory (and the helper method(s) that use it) should be considered as items to help illustrate the final solution.The key file to pay attention to is
mellea/stdlib/components/intrinsic/guardian.py-- I'd say if we're happy with how those look, we'll probably be happy with the overall solution.One item that I don't have a good answer to just yet: the
CRITERIA_BANKstill lives in Mellea, not upstream. Not sure how to best handle that, so input welcome.Testing
Attribution