sys-power/auto-cpufreq: add 3.0.0#452
Conversation
| fi | ||
|
|
||
| # Remove auto-cpufreq log file | ||
| if [ -f "${EROOT}/var/log/auto-cpufreq.log" ]; then |
There was a problem hiding this comment.
i would recommend changing the posix's [ to bash's [[, as per the coding style: https://projects.gentoo.org/qa/policy-guide/ebuild-format.html#pg0101
|
please use git rebase and do a single commit, instead of the new |
changed POSIX's [ to bash's [[, per coding style https://projects.gentoo.org/qa/policy-guide/ebuild-format.html#pg0101 Signed-off-by: d3finit <68038925+d3finit@users.noreply.github.com>
|
We don't do this proxy maintainer stuff with PRs in GURU. If not let me know and I will see how I can get your commit in. |
|
i mean they're not proxy maintaining or adding a new package, rather just doing a version bump, you can simply merge it with pram right? i could be mistaken tho |
|
I don't have write access to the GURU yet, thanks for trying to help get my commit in |
There was a problem hiding this comment.
Thanks for the version bump. I checked this against the v3.0.0 sources and there are still two packaging fixes missing before it is complete:
-
auto_cpufreq/core.pyin 3.0.0 now also uses/opt/auto-cpufreq/turbo-override.pickle, but the ebuild only rewritesoverride.pickle.turbo-override.pickleshould be moved to/var/lib/auto-cpufreqas well. -
auto_cpufreq/gui/objects.pystill hardcodes/usr/local/share/auto-cpufreq/images/icon.pngfor the About dialog. The current sed rules only coverauto_cpufreq/gui/app.py, so the About dialog icon path would stay wrong under Gentoo. -
include python 3.14
Could you please add those too?
|
I opened a follow-up PR with the ebuild from my review comment so the original author can merge it directly: d3finit#1 |
CC: @Schievel1 pinging you since you're the maintainer