x11-themes/nordzy-cursors: add 2.5.0#467
Open
SammyCyber wants to merge 2 commits intogentoo:masterfrom
Open
Conversation
Signed-off-by: Vedant Sule <sulevedant@gmail.com>
Contributor
|
Thanks for the PR. Yes, you should add the metadata of the new remote-id without removing the Github one. About the USE flag, I would leave it as it's now. @MrRoy is the maintainer of this package, so unless he is in favorable to that I would not change that part. |
Signed-off-by: Vedant Sule <sulevedant@gmail.com>
Author
|
Thanks for the info. I've added the new remote-id and also changed the bugs-to link as the github one doesn't exist anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new version 2.5.0 and changes SRC_URI to gitlab, which is the new source of the package. Also uses the tar.bz2 file instead of tar.gz as
pkgcheck scanrecommends it over the latter.pkgcheck scanalso returnsMissingRemoteId: missing <remote-id type="gitlab">gboehm/Nordzy-cursors</remote-id> (inferred from URI 'https://gitlab.com/gboehm/Nordzy-cursors'). I think the way to fix this is to modifymetadata.xml, but I'm not sure how exactly to (do we want to add the gitlab link and keep the github one, as it's a mirror, or replace it entirely?).I was also thinking of adding two local use flags, xcursors and hyprcursors, to limit the type of cursor that is installed. This would avoid the user having to install a huge number of files, but I'm not sure if this would go against the guidelines in CONTRIBUTING.md