[log] log: add debug logging to 5 pkg/ files#26500
Merged
Conversation
Add logger declarations and meaningful log calls to files that lacked instrumentation: maintenance_cron.go (cron frequency decisions), maintenance_workflow_yaml.go (YAML generation parameters and mode branches), action_pins.go (pin resolution outcomes), gateway_logs_aggregation.go (guard policy event categorization), and defaults.go (weight loading paths). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pelikhan
approved these changes
Apr 15, 2026
pelikhan
deleted the
log/go-logger-enhancement-2026-04-15-3907ab696ee54aba
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
logger.New(...)declarations and meaningful debug log calls to five files that previously had no instrumentation.Files changed
pkg/workflow/maintenance_cron.go— log selected cron frequency (every 2h/6h/12h/daily) and side-repo scattered schedule parameterspkg/workflow/maintenance_workflow_yaml.go— log YAML generation entry with key parameters (actionMode, minExpiresDays, cronSchedule) and dev-mode-only job additionspkg/workflow/action_pins.go— log when an action step is successfully pinned vs. skipped (no pin available), and when no embedded pins exist for a repopkg/cli/gateway_logs_aggregation.go— log aggregate calculation entry (server count) and guard policy summary construction (total blocked events)pkg/agentdrain/defaults.go— log whether embedded default weights were loaded, empty, or absentTest plan
make buildpasses with no compilation errorsgo test ./pkg/workflow/...passes (23s)go test ./pkg/cli/...passes (13s)go test ./pkg/agentdrain/...passes🤖 Generated with [Claude Code]((claude.com/redacted)