Fix the ruff formatting issues#1788
Open
happyhuman wants to merge 6 commits intomainfrom
Open
Conversation
happyhuman
requested review from
anifort,
gkcng,
gulliantonio and
mstyer-google
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| except Exception as e: | ||
| logger.error(f"Error in /enhance-image: {e}", exc_info=True) | ||
| raise HTTPException(status_code=500, detail=f"Internal Server Error: {e}") | ||
| raise HTTPException(status_code=500, detail=f"Internal Server Error: {e}") from e |
There was a problem hiding this comment.
[ruff-suggester] reported by reviewdog 🐶
Suggested change
| raise HTTPException(status_code=500, detail=f"Internal Server Error: {e}") from e | |
| raise HTTPException( | |
| status_code=500, detail=f"Internal Server Error: {e}" | |
| ) from e |
| except Exception as e: | ||
| logger.error(f"Error in /edit-frame: {e}", exc_info=True) | ||
| raise HTTPException(status_code=500, detail=f"Internal Server Error: {e}") | ||
| raise HTTPException(status_code=500, detail=f"Internal Server Error: {e}") from e |
There was a problem hiding this comment.
[ruff-suggester] reported by reviewdog 🐶
Suggested change
| raise HTTPException(status_code=500, detail=f"Internal Server Error: {e}") from e | |
| raise HTTPException( | |
| status_code=500, detail=f"Internal Server Error: {e}" | |
| ) from e |
| f"Error generating R2V video for index {index}: {e}", exc_info=True | ||
| ) | ||
| raise HTTPException(status_code=500, detail=f"Internal Server Error: {e}") | ||
| raise HTTPException(status_code=500, detail=f"Internal Server Error: {e}") from e |
There was a problem hiding this comment.
[ruff-suggester] reported by reviewdog 🐶
Suggested change
| raise HTTPException(status_code=500, detail=f"Internal Server Error: {e}") from e | |
| raise HTTPException( | |
| status_code=500, detail=f"Internal Server Error: {e}" | |
| ) from e |
| except Exception as e: | ||
| logger.error(f"Error in /generate-prompt: {e}", exc_info=True) | ||
| raise HTTPException(status_code=500, detail=f"Internal Server Error: {e}") | ||
| raise HTTPException(status_code=500, detail=f"Internal Server Error: {e}") from e |
There was a problem hiding this comment.
[ruff-suggester] reported by reviewdog 🐶
Suggested change
| raise HTTPException(status_code=500, detail=f"Internal Server Error: {e}") from e | |
| raise HTTPException( | |
| status_code=500, detail=f"Internal Server Error: {e}" | |
| ) from e |
| except Exception as e: | ||
| logger.error(f"Error in /generate-custom-prompt: {e}", exc_info=True) | ||
| raise HTTPException(status_code=500, detail=f"Internal Server Error: {e}") | ||
| raise HTTPException(status_code=500, detail=f"Internal Server Error: {e}") from e |
There was a problem hiding this comment.
[ruff-suggester] reported by reviewdog 🐶
Suggested change
| raise HTTPException(status_code=500, detail=f"Internal Server Error: {e}") from e | |
| raise HTTPException( | |
| status_code=500, detail=f"Internal Server Error: {e}" | |
| ) from e |
|
|
||
| def generate_footwear_description( | ||
| client, gemini_model: str = "gemini-2.5-flash", all_images_bytes: list[bytes] = None | ||
| client, gemini_model: str = "gemini-2.5-flash", all_images_bytes: list[bytes] | None = None |
There was a problem hiding this comment.
[ruff-suggester] reported by reviewdog 🐶
Suggested change
| client, gemini_model: str = "gemini-2.5-flash", all_images_bytes: list[bytes] | None = None | |
| client, | |
| gemini_model: str = "gemini-2.5-flash", | |
| all_images_bytes: list[bytes] | None = None, |
|
|
||
| def generate_veo_prompt_r2v( | ||
| client, gemini_model: str = "gemini-2.5-flash", all_images_bytes: list[bytes] = None | ||
| client, gemini_model: str = "gemini-2.5-flash", all_images_bytes: list[bytes] | None = None |
There was a problem hiding this comment.
[ruff-suggester] reported by reviewdog 🐶
Suggested change
| client, gemini_model: str = "gemini-2.5-flash", all_images_bytes: list[bytes] | None = None | |
| client, | |
| gemini_model: str = "gemini-2.5-flash", | |
| all_images_bytes: list[bytes] | None = None, |
| filtered = [ | ||
| (idx, position) | ||
| for idx, position in zip(sampled_indices, product_position_frames) | ||
| for idx, position in zip(sampled_indices, product_position_frames, strict=False) |
There was a problem hiding this comment.
[ruff-suggester] reported by reviewdog 🐶
Suggested change
| for idx, position in zip(sampled_indices, product_position_frames, strict=False) | |
| for idx, position in zip( | |
| sampled_indices, product_position_frames, strict=False | |
| ) |
| ) | ||
| except Exception as e: | ||
| raise HTTPException(status_code=500, detail=f"Failed to generate prompt: {e}") | ||
| raise HTTPException(status_code=500, detail=f"Failed to generate prompt: {e}") from e |
There was a problem hiding this comment.
[ruff-suggester] reported by reviewdog 🐶
Suggested change
| raise HTTPException(status_code=500, detail=f"Failed to generate prompt: {e}") from e | |
| raise HTTPException( | |
| status_code=500, detail=f"Failed to generate prompt: {e}" | |
| ) from e |
Comment on lines
142
to
+144
| with patch( | ||
| "mcp_server.shared.catalog.catalog_mcp.search", return_value=[] | ||
| ) as mock_search: | ||
| ): |
There was a problem hiding this comment.
[ruff-suggester] reported by reviewdog 🐶
Suggested change
| with patch( | |
| "mcp_server.shared.catalog.catalog_mcp.search", return_value=[] | |
| ) as mock_search: | |
| ): | |
| with patch("mcp_server.shared.catalog.catalog_mcp.search", return_value=[]): |
|
There is a problem with the Gemini CLI PR review. Please check the action logs for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.