Maintenance cleanup for test projects#453
Open
voidzcy wants to merge 4 commits intogoogle:masterfrom
Open
Conversation
voidzcy
force-pushed
the
bugfix/clean_up_tests
branch
from
331cf6a to
80a0864
Compare
ejona86
approved these changes
Dec 14, 2020
Collaborator
|
I want that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanup for test projects. Commits can be reviewed separately.
testProjectDependentAppis identical totestProjectDependentexcept the former depends ontestProjectJavaLibrarywhile the latter depends ontestProject. They were the consumer projects that depends on projects built withjava-libraryandjavarespectively. We can simply use thetestProjectDependentAppconsumer project by renamingtestProjectJavaLibrarydirectory totestProjectwhen composing the test project.