Skip to content

Extract configuration fields from task to spec class (1/3)#668

Open
rougsig wants to merge 3 commits intogoogle:masterfrom
rougsig:feat/643-1
Open

Extract configuration fields from task to spec class (1/3)#668
rougsig wants to merge 3 commits intogoogle:masterfrom
rougsig:feat/643-1

Conversation

@rougsig
Copy link
Copy Markdown
Collaborator

@rougsig rougsig commented Jan 24, 2023

Background
To prevent eager task configuration for android, we need to know the list of output folders from generate proto task.

Changes
Extract all configuration fields from GenerateProtoTask to one GenerateProtoTaskSpec field.

Test plan
Green pipelines.

@rougsig rougsig requested a review from ejona86 January 24, 2023 21:10
@rougsig
Copy link
Copy Markdown
Collaborator Author

rougsig commented Jan 24, 2023

note:
small part for fix for #643.

Second Part will be rewrite generateProtoTask {} to use spec directly without task proxy.
Third part will be use extracted values from task as sources for agp/other tasks.

@rougsig rougsig changed the title Extract configuration fields from task to spec class (1/3) Extract configuration fields from task to spec class (1/2) Jan 24, 2023
@rougsig rougsig changed the title Extract configuration fields from task to spec class (1/2) Extract configuration fields from task to spec class (1/3) Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant