fix(bigtable): treat NOT_FOUND and PERMISSION_DENIED on channel refresh as success#16086
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Bigtable client to treat kPermissionDenied and kNotFound as acceptable status codes during connection refreshes, modifying logging in bigtable_stub_factory.cc, RPC tracking in channel_usage.h, and adding corresponding test cases. Review feedback recommends centralizing the status-checking logic to avoid duplication and using the .ok() method for more idiomatic and defensive status validation.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16086 +/- ##
=======================================
Coverage 92.69% 92.70%
=======================================
Files 2351 2351
Lines 218102 218117 +15
=======================================
+ Hits 202178 202205 +27
+ Misses 15924 15912 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Primarily an implementation detail, Bigtable's DynamicChannelPool feature calls the PingAndWarm RPC to prime and refresh channels. Even if this RPC fails due a permission configuration issue, it still indicates a successful path to the service was setup.