Skip to content

fix(bigtable): treat NOT_FOUND and PERMISSION_DENIED on channel refresh as success#16086

Merged
scotthart merged 2 commits intogoogleapis:mainfrom
scotthart:bigtable_pingandwarm_status_update
Apr 28, 2026
Merged

fix(bigtable): treat NOT_FOUND and PERMISSION_DENIED on channel refresh as success#16086
scotthart merged 2 commits intogoogleapis:mainfrom
scotthart:bigtable_pingandwarm_status_update

Conversation

@scotthart
Copy link
Copy Markdown
Member

Primarily an implementation detail, Bigtable's DynamicChannelPool feature calls the PingAndWarm RPC to prime and refresh channels. Even if this RPC fails due a permission configuration issue, it still indicates a successful path to the service was setup.

@scotthart scotthart requested a review from a team as a code owner April 27, 2026 19:17
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Apr 27, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Bigtable client to treat kPermissionDenied and kNotFound as acceptable status codes during connection refreshes, modifying logging in bigtable_stub_factory.cc, RPC tracking in channel_usage.h, and adding corresponding test cases. Review feedback recommends centralizing the status-checking logic to avoid duplication and using the .ok() method for more idiomatic and defensive status validation.

Comment thread google/cloud/bigtable/internal/bigtable_stub_factory.cc Outdated
Comment thread google/cloud/bigtable/internal/channel_usage.h
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.70%. Comparing base (d2e9ba4) to head (3a1cc50).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...e/cloud/bigtable/internal/bigtable_stub_factory.cc 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16086   +/-   ##
=======================================
  Coverage   92.69%   92.70%           
=======================================
  Files        2351     2351           
  Lines      218102   218117   +15     
=======================================
+ Hits       202178   202205   +27     
+ Misses      15924    15912   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart merged commit 8a2d6da into googleapis:main Apr 28, 2026
53 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants