Make extract_requirement_version()'s parsing more robust#545
Merged
Conversation
Previously it didn't check the empty string case, which in practice made no difference (since this function is only used internally during compilation), but fixing this also improves test coverage, so brings us one step closer to being able to enforce it at 100% in CI.
edmorley
added
skip changelog
runesoerensen
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it didn't check the empty string case, which in practice made no difference (since this function is only used internally during compilation), but fixing this also improves test coverage, so brings us one step closer to being able to enforce it at 100% in CI.
GUS-W-21931558.