Skip to content

Improvements to Python version unit tests #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edmorley merged 1 commit into from
Apr 7, 2026
Merged

Improvements to Python version unit tests #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
169 changes: 68 additions & 101 deletions src/python_version.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ pub(crate) enum ResolvePythonVersionError {
#[cfg(test)]
mod tests {
use super::*;
use crate::package_manager::SUPPORTED_PACKAGE_MANAGERS;

#[test]
fn requested_python_version_display() {
Expand All @@ -216,9 +217,22 @@ mod tests {
);
}

#[test]
fn python_version_origin_display() {
assert_eq!(
PythonVersionOrigin::BuildpackDefault.to_string(),
"buildpack default"
);
assert_eq!(
PythonVersionOrigin::PythonVersionFile.to_string(),
".python-version"
);
}

#[test]
fn python_version_display() {
assert_eq!(PythonVersion::new(3, 12, 0).to_string(), "3.12.0");
assert_eq!(PythonVersion::new(2, 7, 18).to_string(), "2.7.18");
assert_eq!(PythonVersion::new(3, 14, 0).to_string(), "3.14.0");
}

#[test]
Expand Down Expand Up @@ -247,30 +261,16 @@ mod tests {

#[test]
fn read_requested_python_version_runtime_txt() {
assert!(matches!(
read_requested_python_version(
Path::new("tests/fixtures/runtime_txt_and_python_version_file"),
PackageManager::Pip
)
.unwrap_err(),
RequestedPythonVersionError::RuntimeTxtNotSupported(PackageManager::Pip)
));
assert!(matches!(
read_requested_python_version(
Path::new("tests/fixtures/runtime_txt_invalid_unicode"),
PackageManager::Poetry
)
.unwrap_err(),
RequestedPythonVersionError::RuntimeTxtNotSupported(PackageManager::Poetry)
));
assert!(matches!(
read_requested_python_version(
Path::new("tests/fixtures/runtime_txt_invalid_version"),
PackageManager::Uv
)
.unwrap_err(),
RequestedPythonVersionError::RuntimeTxtNotSupported(PackageManager::Uv)
));
for &package_manager in SUPPORTED_PACKAGE_MANAGERS {
assert!(matches!(
read_requested_python_version(
Path::new("tests/fixtures/runtime_txt_and_python_version_file"),
package_manager
)
.unwrap_err(),
RequestedPythonVersionError::RuntimeTxtNotSupported(pm) if pm == package_manager
));
}
// We pass a path containing a NUL byte as an easy way to trigger an I/O error.
assert!(matches!(
read_requested_python_version(Path::new("\0/invalid"), PackageManager::Pip).unwrap_err(),
Expand Down Expand Up @@ -385,85 +385,52 @@ mod tests {

#[test]
fn resolve_python_version_eol() {
let requested_python_version = RequestedPythonVersion {
major: 3,
minor: OLDEST_SUPPORTED_PYTHON_3_MINOR_VERSION - 1,
patch: None,
origin: PythonVersionOrigin::PythonVersionFile,
};
assert_eq!(
resolve_python_version(&requested_python_version),
Err(ResolvePythonVersionError::EolVersion(
requested_python_version
))
);

let requested_python_version = RequestedPythonVersion {
major: 3,
minor: OLDEST_SUPPORTED_PYTHON_3_MINOR_VERSION - 1,
patch: Some(0),
origin: PythonVersionOrigin::PythonVersionFile,
};
assert_eq!(
resolve_python_version(&requested_python_version),
Err(ResolvePythonVersionError::EolVersion(
requested_python_version
))
);

let requested_python_version = RequestedPythonVersion {
major: 2,
minor: 7,
patch: Some(18),
origin: PythonVersionOrigin::PythonVersionFile,
};
assert_eq!(
resolve_python_version(&requested_python_version),
Err(ResolvePythonVersionError::EolVersion(
requested_python_version
))
);
for (major, minor) in [
(0, 1),
(1, 0),
(2, 7),
(3, 0),
(3, OLDEST_SUPPORTED_PYTHON_3_MINOR_VERSION - 1),
] {
for patch in [None, Some(0)] {
let requested_python_version = RequestedPythonVersion {
major,
minor,
patch,
origin: PythonVersionOrigin::PythonVersionFile,
};
assert_eq!(
resolve_python_version(&requested_python_version),
Err(ResolvePythonVersionError::EolVersion(
requested_python_version
))
);
}
}
}

#[test]
fn resolve_python_version_unsupported() {
let requested_python_version = RequestedPythonVersion {
major: 3,
minor: NEXT_UNRELEASED_PYTHON_3_MINOR_VERSION,
patch: None,
origin: PythonVersionOrigin::PythonVersionFile,
};
assert_eq!(
resolve_python_version(&requested_python_version),
Err(ResolvePythonVersionError::UnknownVersion(
requested_python_version
))
);

let requested_python_version = RequestedPythonVersion {
major: 3,
minor: NEXT_UNRELEASED_PYTHON_3_MINOR_VERSION,
patch: Some(0),
origin: PythonVersionOrigin::PythonVersionFile,
};
assert_eq!(
resolve_python_version(&requested_python_version),
Err(ResolvePythonVersionError::UnknownVersion(
requested_python_version
))
);

let requested_python_version = RequestedPythonVersion {
major: 4,
minor: 0,
patch: Some(0),
origin: PythonVersionOrigin::PythonVersionFile,
};
assert_eq!(
resolve_python_version(&requested_python_version),
Err(ResolvePythonVersionError::UnknownVersion(
requested_python_version
))
);
for (major, minor) in [
(3, NEXT_UNRELEASED_PYTHON_3_MINOR_VERSION),
(3, 999),
(4, 0),
(5, 0),
] {
for patch in [None, Some(0)] {
let requested_python_version = RequestedPythonVersion {
major,
minor,
patch,
origin: PythonVersionOrigin::PythonVersionFile,
};
assert_eq!(
resolve_python_version(&requested_python_version),
Err(ResolvePythonVersionError::UnknownVersion(
requested_python_version
))
);
}
}
}
}
Empty file removed tests/fixtures/runtime_txt_invalid_unicode/requirements.txt
View file
Open in desktop
Empty file.
1 change: 0 additions & 1 deletion tests/fixtures/runtime_txt_invalid_unicode/runtime.txt
View file
Open in desktop

This file was deleted.

Empty file removed tests/fixtures/runtime_txt_invalid_version/requirements.txt
View file
Open in desktop
Empty file.
1 change: 0 additions & 1 deletion tests/fixtures/runtime_txt_invalid_version/runtime.txt
View file
Open in desktop

This file was deleted.