Skip to content

ci: use gha cache and fix release-please triggers#966

Merged
gildesmarais merged 3 commits intomainfrom
ci/release-please-adjustments
May 1, 2026
Merged

ci: use gha cache and fix release-please triggers#966
gildesmarais merged 3 commits intomainfrom
ci/release-please-adjustments

Conversation

@gildesmarais
Copy link
Copy Markdown
Member

@gildesmarais gildesmarais commented May 1, 2026

This pull request updates the Docker build and caching strategy in the CI and release GitHub Actions workflows. The main improvements are switching to GitHub Actions (GHA) cache storage for Docker layers, simplifying the build and test steps, and ensuring certain jobs are skipped for release-please branches.

CI Workflow improvements:

  • Switched Docker image caching from manual artifact upload/download to using docker/build-push-action with GHA cache storage, streamlining the build and test process (.github/workflows/ci.yml). [1] [2]
  • Added job conditions to skip Docker build and test steps for release-please branches in pull requests, reducing unnecessary CI runs (.github/workflows/ci.yml). [1] [2]

Release Workflow improvements:

  • Removed local Docker cache management and replaced with GHA cache for Docker buildx, simplifying cache handling and improving cache sharing across runners (.github/workflows/release.yml). [1] [2] [3]

These changes make the workflows more efficient, easier to maintain, and better leverage GitHub Actions built-in caching for Docker images.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions CI/release workflows to use GitHub Actions (GHA) BuildKit caching for Docker builds and to avoid running some Docker-related CI jobs on release-please PR branches.

Changes:

  • Switch Docker Buildx layer caching from local filesystem cache to type=gha in the release workflow.
  • Update CI Docker build/test jobs to use Buildx + type=gha caching instead of exporting/importing a tarball artifact.
  • Skip Docker build/test jobs for release-please--* pull requests.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/release.yml Replaces local Buildx cache steps with GHA cache configuration for Docker publish.
.github/workflows/ci.yml Moves Docker smoke build/test to Buildx + GHA cache and adds branch-based job skipping for release-please PRs.

Comment thread .github/workflows/ci.yml Outdated
@gildesmarais gildesmarais requested a review from Copilot May 1, 2026 12:37
@gildesmarais gildesmarais marked this pull request as ready for review May 1, 2026 12:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CI/release GitHub Actions workflows to use the GitHub Actions cache backend for Docker Buildx and adjusts CI execution for release-please PR branches.

Changes:

  • Switch Docker build caching in the release workflow from local filesystem caching to type=gha.
  • Rework CI Docker smoke image build/test flow to use Buildx + type=gha caching and skip the Docker jobs on release-please--* PR branches.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/release.yml Replaces local Buildx layer caching with GitHub Actions cache (type=gha) for Docker publish builds.
.github/workflows/ci.yml Uses Buildx + type=gha for smoke builds, adds gating to skip Docker jobs on release-please PR branches, and changes how the smoke image is made available to tests.

Comment thread .github/workflows/ci.yml
Comment on lines +161 to +167
- name: Load Docker smoke image from cache
uses: docker/build-push-action@v7
with:
context: .
load: true
tags: html2rss/web
cache-from: type=gha
Comment thread .github/workflows/ci.yml Outdated
load: true
tags: html2rss/web
cache-from: type=gha
# No cache-to here; we only want to read the image built in the previous job
Comment thread .github/workflows/ci.yml
path: /tmp/html2rss-web-smoke-image.tar
retention-days: 1
context: .
load: true
@gildesmarais gildesmarais merged commit 4f1c416 into main May 1, 2026
14 checks passed
@gildesmarais gildesmarais deleted the ci/release-please-adjustments branch May 1, 2026 12:47
@gildesmarais gildesmarais restored the ci/release-please-adjustments branch May 1, 2026 13:02
@gildesmarais gildesmarais deleted the ci/release-please-adjustments branch May 1, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants