Fix CSR fallback crash when SSR returns non-string error#73
Open
m5r wants to merge 1 commit intoinertiajs:mainfrom
Open
Fix CSR fallback crash when SSR returns non-string error#73m5r wants to merge 1 commit intoinertiajs:mainfrom
m5r wants to merge 1 commit intoinertiajs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a Node.js SSR worker crashes (e.g. V8 OOM with exit code 134), the
nodejslibrary returns{:error, {:node_js_worker_exit, <tuple>}}instead of{:error, "string message"}.In
send_response/1, this matches{:error, message}wheremessageis a tuple. The Logger call on line 845 does"...\n\n#{message}", which callsString.Chars.to_string/1on the tuple and raisesProtocol.UndefinedError. The CSR fallback on the next line never executes, and the user gets a 500.The
raise_on_ssr_failurepath has the same issue:RenderErrorexpectsmessageto be a string.Fix
Coerce
messagewithinspect/1when it's not a binary, before logging or raising:Test
Added
test/js/ssr-crash.jsthat callsprocess.exit(134)to simulate a worker crash. The test asserts the request still returns 200 (CSR fallback) instead of crashing.