Improvements for the deploy windows script.#3680
Open
JaminShanti wants to merge 5 commits intojamulussoftware:mainfrom
Open
Improvements for the deploy windows script.#3680JaminShanti wants to merge 5 commits intojamulussoftware:mainfrom
JaminShanti wants to merge 5 commits intojamulussoftware:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Modernizes deploy_windows.ps1 to reduce external dependencies (removing VSSetup), improve build resilience on newer Visual Studio toolchains, and add better diagnostics/guardrails during Windows packaging.
Changes:
- Replaced VSSetup-based VS detection with native
vswhere.exeand added dynamicPlatformToolsetselection. - Added centralized logging, debug/skip toggles, and improved dependency download/caching behavior.
- Added an installer “safety gate” to prevent producing an empty package when no binaries were built.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Exiting comment, not mine. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows: Optimize deployment script and remove VSSetup dependency
Short description of changes
This PR modernizes and optimizes the
deploy_windows.ps1script to streamline the build process and eliminate external PowerShell module requirements. Key improvements include:VSSetupmodule with nativevswhere.execalls for locating Visual Studio installations, removing the need for NuGet/Package Provider setup.PlatformToolsetdetection (e.g.,v143for VS 2022) to ensure the script works out-of-the-box on newer dev environments.-Skip64Bitand-Skip32Bitflags for targeted debugging of the build pipeline, along with improved logging and registry-based Qt discovery fallbacks.CHANGELOG: Windows: Optimized the deployment script to remove module dependencies and improve build reliability.
Context: Fixes an issue?
This PR improves the local contributor experience on Windows by making the build environment more robust and easier to debug without external dependencies.
Does this change need documentation? What needs to be documented and how?
No user-facing documentation is required. Internal documentation for the new skip flags is handled via the script's
paramblock comments.Status of this Pull Request
Working implementation.
What is missing until this pull request can be merged?
Verification of the GitHub CI "Autobuild" checks once the PR is opened.
Checklist
AUTOBUILD: Please build all targets