Skip to content

Make getLoadedBuilds not to copy all coreMap builds#26636

Merged
timja merged 2 commits intojenkinsci:masterfrom
dukhlov:build-ref-resolution-refactoring
Apr 18, 2026
Merged

Make getLoadedBuilds not to copy all coreMap builds#26636
timja merged 2 commits intojenkinsci:masterfrom
dukhlov:build-ref-resolution-refactoring

Conversation

@dukhlov
Copy link
Copy Markdown
Contributor

@dukhlov dukhlov commented Apr 13, 2026

Related to #26596

This change refactors getLoadedBuilds() to return a BuildReferenceMapAdapter backed by the existing core map with a LoadedOnlyBuildReferenceResolver that only returns builds already loaded into memory, without triggering disk loads. This avoids the unnecessary copy and allocation.

As part of this refactoring:

  • Extracted BuildReferenceResolver interface from the inner Resolver interface in BuildReferenceMapAdapter, separating build reference resolution logic from build metadata (BuildTypeDescriptor)
  • Introduced LoadedOnlyBuildReferenceResolver — resolves only in-memory references, used by getLoadedBuilds()
  • Introduced DefaultBuildReferenceResolver — resolves references with disk loading fallback, used by all other operations

Testing done

Manual testing done on local environment, Jenkins PR automated testing done

Screenshots (UI changes only)

Before

After

Proposed changelog entries

  • Avoid unnecessary copy of all loaded builds in AbstractLazyLoadRunMap.getLoadedBuilds().

Proposed changelog category

/label internal

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jglick @timja @bennettzhu1

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@dukhlov dukhlov force-pushed the build-ref-resolution-refactoring branch 11 times, most recently from db15ef1 to eec8549 Compare April 13, 2026 22:35
@timja
Copy link
Copy Markdown
Member

timja commented Apr 14, 2026

fyi spotbugs failure

@dukhlov dukhlov force-pushed the build-ref-resolution-refactoring branch 17 times, most recently from c221cca to a8f3fce Compare April 15, 2026 16:32
Also:
- optimise LazyBuildMixin.getEstimatedDurationCandidates method,
  not to perform double iterations of the loaded builds,
- Optimise CopyOnWriteMap.replaceBy (remove copy then cleanup
  before replace).
@dukhlov dukhlov force-pushed the build-ref-resolution-refactoring branch from a8f3fce to cee1395 Compare April 15, 2026 18:19
@dukhlov dukhlov marked this pull request as ready for review April 15, 2026 20:29
Copy link
Copy Markdown
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timja timja requested a review from jglick April 15, 2026 20:43
Copy link
Copy Markdown
Contributor

@bennettzhu1 bennettzhu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Copy link
Copy Markdown
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process.

/label ready-for-merge

@comment-ops-bot comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions Bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Apr 17, 2026
@github-actions github-actions Bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Apr 17, 2026
@timja timja merged commit b909f82 into jenkinsci:master Apr 18, 2026
17 checks passed
@MarkEWaite MarkEWaite added the pct-successful This PR has successfully passed the full plugin-compatibility-test suite label Apr 18, 2026
@krisstern krisstern added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal pct-successful This PR has successfully passed the full plugin-compatibility-test suite ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants