Publish Scan Results to Gitlab Dashboards#1268
Open
orto17 wants to merge 15 commits intojfrog:v3_erfrom
Open
Conversation
orto17
added
the
safe to test
github-actions
Bot
removed
the
safe to test
orto17
changed the title
orto17
added
the
safe to test
github-actions
Bot
removed
the
safe to test
github-actions
Bot
removed
the
safe to test
attiasas
approved these changes
May 7, 2026
Contributor
attiasas
left a comment
attiasas
left a comment
There was a problem hiding this comment.
Nice work! check out my comments
Comment on lines
+158
to
+163
| if repository.Params.Git.GitProvider == vcsutils.GitLab && repository.Params.Git.GitlabScanResultsOutputDir != "" { | ||
| log.Debug(fmt.Sprintf("Trying to save scan results to directory: %s", repository.Params.Git.GitlabScanResultsOutputDir)) | ||
| if writeErr := utils.WriteScanResultsToDir(repository.Params.Git.GitlabScanResultsOutputDir, scanResults, sr.scanDetails.StartTime); writeErr != nil { | ||
| log.Warn(fmt.Sprintf("Failed to write scan results to directory: %s", writeErr.Error())) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe export to helper func? similar to uploadResultsToGithubDashboardsIfNeeded?
| return err | ||
| } | ||
|
|
||
| func WriteScanResultsToDir(outputDir string, scanResults *results.SecurityCommandResults, startTime time.Time) error { |
Contributor
There was a problem hiding this comment.
Suggested change
| func WriteScanResultsToDir(outputDir string, scanResults *results.SecurityCommandResults, startTime time.Time) error { | |
| func WriteScanResultsToGitlabDir(outputDir string, scanResults *results.SecurityCommandResults, startTime time.Time) error { |
maybe give it more detailed name, this may be confusing to future devs,
Comment on lines
+505
to
+514
| path := filepath.Join(outputDir, cyclonedxOutputFilename) | ||
| f, err := os.Create(path) | ||
| if err != nil { | ||
| return fmt.Errorf("create file: %w", err) | ||
| } | ||
| defer func() { _ = f.Close() }() | ||
| encoder := cyclonedx.NewBOMEncoder(f, cyclonedx.BOMFileFormatJSON) | ||
| if err = encoder.Encode(&bom); err != nil { | ||
| return fmt.Errorf("encode CycloneDX: %w", err) | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| path := filepath.Join(outputDir, cyclonedxOutputFilename) | |
| f, err := os.Create(path) | |
| if err != nil { | |
| return fmt.Errorf("create file: %w", err) | |
| } | |
| defer func() { _ = f.Close() }() | |
| encoder := cyclonedx.NewBOMEncoder(f, cyclonedx.BOMFileFormatJSON) | |
| if err = encoder.Encode(&bom); err != nil { | |
| return fmt.Errorf("encode CycloneDX: %w", err) | |
| } | |
| err = utils.SaveCdxContentToFile(filepath.Join(outputDir, cyclonedxOutputFilename), bom) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frogbot can now write scan output to a directory when it runs against GitLab, using the JF_SCAN_RESULTS_OUTPUT_DIR environment variable. The directory gets cyclonedx.json (SBOM) and gl-dependency-scanning-report.json in GitLab’s dependency-scanning format, so pipelines can publish them to GitLab’s security UI. This runs alongside the existing repository scan flow (detection and auto-fix behavior are unchanged when enabled).