[WIP] Introduce ruff checks#296
Draft
LecrisUT wants to merge 10 commits intojnikula:masterfrom
Draft
Conversation
No longer needed for quite a while now, and the build-system is hatchling not setuptools, so it shouldn't even work properly. Signed-off-by: Cristian Le <git@lecris.dev>
Primarily needed for tests and docs for downstream packaging, but in practice, there is no reason to be conservative on the sdist size for non-compiled python packages. Only packagers would be using the sdist and they would rather have the source as close to the git archive as possible (and hatchling does that by default) Signed-off-by: Cristian Le <git@lecris.dev>
Trying to mirror all existing checks into pre-commit. `mypy` was intentionally left out because it does not work well with dependencies Signed-off-by: Cristian Le <git@lecris.dev>
These are not yet being used in the CI or Makefile. More design work is needed Signed-off-by: Cristian Le <git@lecris.dev>
Also convert them to `dependency-groups` Signed-off-by: Cristian Le <git@lecris.dev>
The upgrades is postponed to use uv.lock instead or pylock.toml if pip learns how to use it Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
For now disabling the majority of checks to minimize the impact Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
This was referenced Nov 28, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires a lot of consideration on how to configure, and how to avoid a huge PR change
Depends on #295