Fix duplicate phone number prefix 145 in zh_CN locale#2343
Open
r266-tech wants to merge 1 commit intojoke2k:masterfrom
Open
Fix duplicate phone number prefix 145 in zh_CN locale#2343r266-tech wants to merge 1 commit intojoke2k:masterfrom
r266-tech wants to merge 1 commit intojoke2k:masterfrom
Conversation
Remove duplicate 145 from the phonenumber_prefixes list. The list had 30 entries but only 29 unique prefixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
zh_CNphone number provider has a duplicate entry for prefix145in itsphonenumber_prefixeslist.The Bug
The list contains 30 entries but only 29 unique prefixes -
145appears twice. This means:145is generated approximately 2x more often than other prefixesThe Fix
Remove the duplicate
145entry from the list.Before
After