Fix UnicodeEncodeError in CLI docs on non-UTF consoles#2362
Open
RedZapdos123 wants to merge 1 commit intojoke2k:masterfrom
Open
Fix UnicodeEncodeError in CLI docs on non-UTF consoles#2362RedZapdos123 wants to merge 1 commit intojoke2k:masterfrom
RedZapdos123 wants to merge 1 commit intojoke2k:masterfrom
Conversation
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes done:
Fixes a CLI crash when printing provider docs to terminals using non-UTF encodings (for example cp950 on Windows).
Problem Explaination:
python -m fakercan raiseUnicodeEncodeErrorwhile printing provider examples that include characters unsupported by the output encoding (such as emoji on cp950).This happens in
print_provider()when writing formatted documentation lines.Fix:
_encode_for_output()infaker/cli.pyto safely encode output strings for the active stream encoding.backslashreplacewhen characters are not encodable, so output remains printable and the CLI does not crash.print_provider().test_print_provider_handles_non_utf_outputto verify cp950 output no longer crashes and preserves escaped content.Fixes #2361
AI Assistance Disclosure (as REQUIRED):
AI tool used: GitHub Copilot (GPT-5.3-Codex), used for code drafting and test drafting. All changes were manually reviewed and validated by running tests.
Checklist:
make lint.The screenshots of the tests run, for validation (ran on WSL):