Document JsonApiEndpoints enum

[verdie-g]

Closes #1298

QUALITY CHECKLIST

• Changes implemented in code
• Complies with our contributing guidelines
• Adapted tests
• Documentation updated

[codecov]

Codecov Report

Merging #1301 (d7962b7) into master (68e1854) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1301   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files         268      268           
  Lines        8795     8795           
=======================================
  Hits         8182     8182           
  Misses        613      613           

[bkoelman]

Thanks. I'll get back to this next month, after my break.

[bkoelman]

Please note the line at the top of this file:

// IMPORTANT: An internal copy of this type exists in the SourceGenerators project. Keep these in sync when making changes.

These changes should be replicated in the other file.

[verdie-g]

The CI error is weird, I did run cleanupcode 🤔

[bkoelman]

The CI error is weird, I did run cleanupcode 🤔

Strange indeed. Running locally on Windows does not produce a diff. I haven't seen this happen before, will investigate. What OS are you using?

[verdie-g]

Windows 11 and

$ dotnet --info
.NET SDK:
 Version:   7.0.400
 Commit:    73bf45718d

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.22621
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\7.0.400\

Host:
  Version:      7.0.10
  Architecture: x64
  Commit:       a6dbb800a4

.NET SDKs installed:
  6.0.413 [C:\Program Files\dotnet\sdk]
  7.0.400 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.21 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 7.0.10 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 6.0.21 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 7.0.10 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 6.0.21 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 7.0.10 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
  None

Environment variables:
  Not set

global.json file:
  Not found

[verdie-g]

Could it be a line-ending thing? Maybe locally I'm using CRLF and the CI is using LF the number of characters on the line is different?

[bkoelman]

Could it be a line-ending thing? Maybe locally I'm using CRLF and the CI is using LF the number of characters on the line is different?

Yes, but I don't think that should matter. It has always worked that way. I've created a temporary PR #1304 to investigate.

[bkoelman]

@verdie-g Sorry this is taking so long. I've opened a bug at https://youtrack.jetbrains.com/issue/RSRP-494002, but it hasn't been triaged yet.

Meanwhile, can you please merge or rebase on the latest changes in master? I've replaced AppVeyor with GitHub Actions. This is a nice opportunity to test whether everything works from a community PR. I can't do it myself because my account has write permissions and I'd like to confirm builds work without that. Sadly, it won't fix the cleanupcode bug though.

[verdie-g]

Looks like it's failing for macos

[bkoelman]

Looks like it's failing for macos

Yes, same as linux.

[bkoelman]

@verdie-g I'd like to keep this PR open. I suspect this was closed unintentionally as a side effect of deleting your fork. I'm unable to reopen because your fork no longer exists. Can you restore it?

We still want to take this PR. The related issue has been triaged with priority critical, so I have high hopes a fix will become available soon.

[verdie-g]

I completely forgot about that PR. I'll try restoring the fork when I get some time.

[bkoelman]

Superseded by #1423.