Request meta tests boilerplate

[mrmarcosmagalhaes]

Closes #1500

QUALITY CHECKLIST

• Changes implemented in code
• Complies with our contributing guidelines
• Adapted tests
• Documentation updated

[bkoelman]

Thanks, this looks great!

I've changed the base of this PR, so that status checks run.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (b7a7307) to head (72ef335).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1746   +/-   ##
=======================================
  Coverage   92.24%   92.25%           
=======================================
  Files         437      437           
  Lines       14860    14860           
  Branches     2451     2451           
=======================================
+ Hits        13708    13709    +1     
+ Misses        709      708    -1     
  Partials      443      443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bkoelman]

@mrmarcosmagalhaes, do you still want to complete the work on this PR? If not, please let me know, so I can pick up from here.

[mrmarcosmagalhaes]

Good morning I want to finalize this pull request. Sorry for the late reply. I had another child and i didn't have so much time. Until to next weekend i will implement your suggestions 👌 Regards, Marcos Magalhães A quarta, 3/12/2025, 01:54, Bart Koelman ***@***.***> escreveu:

…

*bkoelman* left a comment (json-api-dotnet/JsonApiDotNetCore#1746) <#1746 (comment)> @mrmarcosmagalhaes <https://github.com/mrmarcosmagalhaes>, do you still want to complete the work on this PR? If not, please let me know, so I can pick up from here. — Reply to this email directly, view it on GitHub <#1746 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEOSMSAGDVHA64QHCUHPVWL37Y7FXAVCNFSM6AAAAACBUJV36GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMBUGY4TKNJTHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[bkoelman]

Congratulations! Looking forward to your contribution.

[mrmarcosmagalhaes]

@bkoelman Completed and consolidated RequestMetaTests.
All resource, relationship, and atomic operations now have a single integration test per endpoint, covering all valid meta locations.
Added full coverage for atomic relationship operations (to-one and to-many), fully aligned with the JSON:API spec.
Sorry for the late push but my life right now is not easy.

[bkoelman]

Thanks for addressing all the feedback. Minus the comments posted here, I think RequestMetaTests is good to go. I've added a comment requesting to sync up the operations tests, which I'll take a closer look at next time.

[bkoelman]

I've left some more feedback. The tests for operations are not quite in sync yet.

[bkoelman]

I've completed another review pass. I've started with RequestMetaTests, then diffed it against OperationsRequestMetaTests. This means that new feedback on the first file should be applied to the second file too, where applicable, to keep them in sync.

[bkoelman]

Not all feedback from the previous round has been addressed yet.

[mrmarcosmagalhaes]

Done. Can you review Bart? Thanks. Bart Koelman ***@***.***> escreveu (quarta, 28/01/2026 à(s) 02:18):

…

***@***.**** requested changes on this pull request. Not all feedback from the previous round has been addressed yet. ------------------------------ In test/JsonApiDotNetCoreTests/IntegrationTests/Meta/OperationsRequestMetaTests.cs <#1746 (comment)> : > + store.Document.Operations.Should().ContainSingle().Which.With(operation => + { + operation.Should().NotBeNull(); + + operation.Meta.Should().BeEquivalentToJson(operationMeta); + + operation.Data.ManyValue.Should().HaveCount(2); + + operation.Data.ManyValue[0].Meta.Should().BeEquivalentToJson(identifierMeta1); + + operation.Data.ManyValue[1].Meta.Should().BeEquivalentToJson(identifierMeta2); + }); + } + + [Fact] + public async Task Accepts_meta_in_add_ToMany_relationship_operation() ⬇️ Suggested change - public async Task Accepts_meta_in_add_ToMany_relationship_operation() + public async Task Accepts_meta_in_add_to_ToMany_relationship_operation() ------------------------------ In test/JsonApiDotNetCoreTests/IntegrationTests/Meta/OperationsRequestMetaTests.cs <#1746 (comment)> : > + store.Document.Operations.Should().ContainSingle().Which.With(operation => + { + operation.Should().NotBeNull(); + + operation.Meta.Should().BeEquivalentToJson(operationMeta); + + operation.Data.ManyValue.Should().HaveCount(2); + + operation.Data.ManyValue[0].Meta.Should().BeEquivalentToJson(identifierMeta1); + + operation.Data.ManyValue[1].Meta.Should().BeEquivalentToJson(identifierMeta2); + }); + } + + [Fact] + public async Task Accepts_meta_in_remove_operation_from_ToMany_relationship() ⬇️ Suggested change - public async Task Accepts_meta_in_remove_operation_from_ToMany_relationship() + public async Task Accepts_meta_in_remove_from_ToMany_relationship_operation() — Reply to this email directly, view it on GitHub <#1746 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEOSMSGF5VLQUI3CTD2I47D4JAL6LAVCNFSM6AAAAACBUJV36GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTOMJUGI3TMNZXGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Cumprimentos, Marcos Magalhães

[bkoelman]

Done. Can you review Bart? Thanks.

The same still applies: not all feedback has been addressed yet. Click "Load more" in the GitHub Web UI (Conversation tab) to view them.

[bkoelman]

Thanks for your contribution!

[mrmarcosmagalhaes]

Thank you for the reviews and for allowing this form of contribution. I will continue to support this project if in the meantime any other project emerges that can help, tell me. A sábado, 31/01/2026, 10:27, Bart Koelman ***@***.***> escreveu:

…

***@***.**** approved this pull request. Thanks for your contribution! — Reply to this email directly, view it on GitHub <#1746 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEOSMSCWWL4MGBAB6FKBKZL4JR7R7AVCNFSM6AAAAACBUJV36GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTOMZSGIZTQNRZG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>