Replace deprecated KeyboardEvent.keyCode by KeyboardEvent.code#811
Open
coelhucas wants to merge 2 commits intojxnblk:masterfrom
Open
Replace deprecated KeyboardEvent.keyCode by KeyboardEvent.code#811coelhucas wants to merge 2 commits intojxnblk:masterfrom
KeyboardEvent.keyCode by KeyboardEvent.code#811coelhucas wants to merge 2 commits intojxnblk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having some trouble trying to enter presenter mode by pressing
Option + P. After some time banging my head on the keyboard, I noticed that actually it was an extension in my browser capturing the same shortcut to perform a Picture in Picture (so here's the tip for whoever might be facing the same issue in MacOS).Since I was already with the project cloned in my machine, I decided to also do this replacing to remove the deprecated
keyCodefield from KeyboardEvent, just to avoid it becoming a breaking change in the near future.