Skip to content

Migrate from deprecated v1 Endpoints to discovery.k8s.io/v1 EndpointSlice#9032

Open
creydr wants to merge 1 commit intoknative:mainfrom
creydr:migrate-to-endpoint-slice
Open

Migrate from deprecated v1 Endpoints to discovery.k8s.io/v1 EndpointSlice#9032
creydr wants to merge 1 commit intoknative:mainfrom
creydr:migrate-to-endpoint-slice

Conversation

@creydr
Copy link
Copy Markdown
Member

@creydr creydr commented Apr 21, 2026

The Kubernetes v1 Endpoints API is deprecated in v1.33+.

Proposed Changes

  • 🧹 Migrate from deprecated v1 Endpoints to discovery.k8s.io/v1 EndpointSlice

@knative-prow knative-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 21, 2026
@knative-prow knative-prow Bot requested review from Leo6Leo and aliok April 21, 2026 14:21
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 52.25806% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.95%. Comparing base (b3edbad) to head (5afe170).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/testing/endpointslice.go 0.00% 19 Missing ⚠️
pkg/reconciler/testing/v1/endpointslice.go 0.00% 19 Missing ⚠️
pkg/reconciler/eventtransform/controller.go 0.00% 6 Missing ⚠️
pkg/apis/duck/lifecycle_helper.go 0.00% 5 Missing ⚠️
...econciler/inmemorychannel/controller/controller.go 50.00% 4 Missing and 1 partial ⚠️
pkg/reconciler/broker/broker.go 80.00% 2 Missing ⚠️
pkg/reconciler/broker/controller.go 85.71% 1 Missing and 1 partial ⚠️
pkg/reconciler/eventtransform/eventtransform.go 89.47% 1 Missing and 1 partial ⚠️
...iler/inmemorychannel/controller/inmemorychannel.go 89.47% 2 Missing ⚠️
pkg/reconciler/testing/listers.go 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9032      +/-   ##
==========================================
- Coverage   51.07%   50.95%   -0.12%     
==========================================
  Files         409      411       +2     
  Lines       21999    22069      +70     
==========================================
+ Hits        11235    11246      +11     
- Misses       9901     9958      +57     
- Partials      863      865       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…lice

The Kubernetes v1 Endpoints API is deprecated in v1.33+. This migrates
the Broker, InMemoryChannel, and EventTransform reconcilers to use
EndpointSlice with label-based listing instead of name-based Endpoints
lookups, and updates RBAC roles, test helpers, and all test files.
@creydr creydr force-pushed the migrate-to-endpoint-slice branch from 66960b5 to 5afe170 Compare April 21, 2026 15:16
@creydr creydr changed the title [WIP] Migrate from deprecated v1 Endpoints to discovery.k8s.io/v1 EndpointSlice Migrate from deprecated v1 Endpoints to discovery.k8s.io/v1 EndpointSlice Apr 22, 2026
@knative-prow knative-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2026
@creydr
Copy link
Copy Markdown
Member Author

creydr commented Apr 22, 2026

Downstream rabbitmq tests are failing, because it needs to migrate to the "new" eventing API

@creydr
Copy link
Copy Markdown
Member Author

creydr commented Apr 22, 2026

/cc @maschmid @Cali0707

@knative-prow knative-prow Bot requested review from Cali0707 and maschmid April 22, 2026 13:46
@creydr
Copy link
Copy Markdown
Member Author

creydr commented Apr 29, 2026

@Cali0707 @maschmid can you PTAL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant