Skip to content

linode: add Linode (Akamai) node configuration and identity#18166

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
moshevayner:add-linode-provider-draft
Apr 10, 2026
Merged

linode: add Linode (Akamai) node configuration and identity#18166
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
moshevayner:add-linode-provider-draft

Conversation

@moshevayner
Copy link
Copy Markdown
Member

@moshevayner moshevayner commented Apr 6, 2026

Implements nodeup support for Linode (Akamai) instances including OS-level configuration and node identity for kops-controller.

This is part of the broader effort to introduce Linode (Akamai) as an additional provider for kOps.

Signed-off-by: Moshe Vayner moshe@vayner.me

@moshevayner
feat(deps): added linode-go dependency
a852904 
Including output from `go mod vendor` and `go mod tidy`

Signed-off-by: Moshe Vayner <moshe@vayner.me>
@moshevayner
test(e2e): make gomod
91e4fba 
Signed-off-by: Moshe Vayner <moshe@vayner.me>
@k8s-ci-robot k8s-ci-robot requested a review from hakman April 6, 2026 19:42
@k8s-ci-robot k8s-ci-robot requested a review from zetaab April 6, 2026 19:42
@k8s-ci-robot k8s-ci-robot added area/nodeup size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 6, 2026
@moshevayner moshevayner marked this pull request as draft April 6, 2026 19:47
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2026
@moshevayner moshevayner force-pushed the add-linode-provider-draft branch from b4d28ca to a291fc1 Compare April 6, 2026 20:02
@moshevayner
Copy link
Copy Markdown
Member Author

moshevayner commented Apr 6, 2026

/test all

@moshevayner moshevayner marked this pull request as ready for review April 6, 2026 20:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2026
@k8s-ci-robot k8s-ci-robot requested a review from olemarkus April 6, 2026 20:15
@moshevayner
Copy link
Copy Markdown
Member Author

moshevayner commented Apr 6, 2026

/retest

@moshevayner moshevayner force-pushed the add-linode-provider-draft branch from a291fc1 to 60546ad Compare April 6, 2026 22:57
@moshevayner
Copy link
Copy Markdown
Member Author

moshevayner commented Apr 6, 2026

/retest

@moshevayner
Copy link
Copy Markdown
Member Author

moshevayner commented Apr 8, 2026

/cc @hakman @rifelpet
Thanks! 🙏🏼

@k8s-ci-robot k8s-ci-robot requested a review from rifelpet April 8, 2026 14:19
hakman
hakman requested changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@hakman hakman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @moshevayner! 🚀
Mostly LGTM as very early stage, but have some Q.

Comment thread util/pkg/vfs/context.go Outdated
Comment thread upup/pkg/fi/cloudup/linode/authenticator.go
Comment thread upup/pkg/fi/cloudup/linode/authenticator.go
@moshevayner moshevayner force-pushed the add-linode-provider-draft branch 2 times, most recently from 860f99a to 7c977a0 Compare April 9, 2026 20:53
@moshevayner
Copy link
Copy Markdown
Member Author

moshevayner commented Apr 9, 2026

/retest

3 similar comments
@moshevayner
Copy link
Copy Markdown
Member Author

moshevayner commented Apr 9, 2026

/retest

@moshevayner
Copy link
Copy Markdown
Member Author

moshevayner commented Apr 9, 2026

/retest

@moshevayner
Copy link
Copy Markdown
Member Author

moshevayner commented Apr 9, 2026

/retest

hakman
hakman requested changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more Q, but almost there.

Comment thread nodeup/pkg/model/linode.go Outdated
Comment thread nodeup/pkg/model/linode.go Outdated
Comment thread upup/pkg/fi/cloudup/linode/authenticator.go
@moshevayner
feat(nodeup): add Linode (Akamai) node configuration and identity
c8fff02 
Implements `nodeup` support for Linode (Akamai) instances including OS-level configuration and node identity for kops-controller.

This is part of the broader effort to introduce Linode (Akamai) as an additional provider for kOps.

Signed-off-by: Moshe Vayner <moshe@vayner.me>
@moshevayner moshevayner force-pushed the add-linode-provider-draft branch from 7c977a0 to c8fff02 Compare April 10, 2026 16:38
@hakman hakman changed the title feat(nodeup): add Linode (Akamai) node configuration and identity linode: add Linode (Akamai) node configuration and identity Apr 10, 2026
@hakman
Copy link
Copy Markdown
Member

hakman commented Apr 10, 2026

@moshevayner Please squash the commits before merging. Thanks!

@moshevayner
Copy link
Copy Markdown
Member Author

moshevayner commented Apr 10, 2026 •
edited
Loading

@moshevayner Please squash the commits before merging. Thanks!

@hakman I intentionally separated them so that:

  • First commit is only adding the linode-go client and go mod vendor && go mod tidy
  • Second commit is generated from make gomod output
  • Third commit is my actual code changes

It felt cleaner that way and easier to distinguish my changes from generated ones.
I suppose I can consolidate commits 1 & 2, but wouldn't it make sense to keep the last one separate?

Either way I'm okay with whatever you prefer, let me know 😄

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 10, 2026

@moshevayner: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-kubernetes-e2e-ubuntu-gce-build c8fff02 link false /test pull-kops-kubernetes-e2e-ubuntu-gce-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@moshevayner
Copy link
Copy Markdown
Member Author

moshevayner commented Apr 10, 2026

/retest

@k8s-ci-robot k8s-ci-robot merged commit e570414 into kubernetes:master Apr 10, 2026
27 of 28 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Apr 10, 2026
@moshevayner moshevayner deleted the add-linode-provider-draft branch April 10, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman hakman approved these changes

@zetaab zetaab Awaiting requested review from zetaab

@olemarkus olemarkus Awaiting requested review from olemarkus

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@hakman hakman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/kops-controller area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

3 participants

@moshevayner @hakman @k8s-ci-robot