Open
Conversation
echen5503
reviewed
Mar 31, 2026
| LBFGS_options["maxfun"] = maxfun if maxfun is not None else int(maxiter * 1.25) | ||
| LBFGS_options["maxls"] = maxls | ||
|
|
||
| # Backend-dependent options |
Contributor
There was a problem hiding this comment.
Please verify my understanding: set_hvd_opt_options sets the LFBGS options along with doing the backend-specific operations, but in reality set_LFBGS_options should handle this itself, causing the bug that when you call set_LGBGS_options by itself, it wont update iter_per_step and fun_per_step.
Contributor
Author
There was a problem hiding this comment.
set_LBFGS_options is expected to update all L-BFGS-related parameters, including iter_per_step and fun_per_step used in the Paddle and PyTorch backends. However, the current implementation does not update them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
dde.optimizers.set_LBFGS_optionsso that it correctly updatesiter_per_stepandfun_per_stepused by L-BFGS in PyTorch/Paddle backends.Before PR:
After PR: