fix: remove end-of-life PHP version references from htaccess files#40684
Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Open
fix: remove end-of-life PHP version references from htaccess files#40684lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Conversation
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove references to end-of-life PHP versions (PHP 5.x and PHP 7.x) from
.htaccessfiles.Problem
Several
.htaccessfiles contain:<IfModule mod_php7.c>blocks — Duplicate configuration blocks for PHP 7.x alongside themod_php.cblocks for PHP 8+. PHP 7.4 (the last 7.x release) reached EOL in November 2022, and Magento 2.4.7+ requires PHP 8.2+.Suhosin extension reference —
php_flag suhosin.session.cryptua offinside themod_php7.cblock. The Suhosin extension is abandoned and never supported PHP 7+, making this directive dead code even on PHP 7.PHP 5 CGI references — Commented-out
php5-cgihandler,x-mapp-php5type definitions, andphp5.inireferences from hosting-specific workarounds that are over a decade old.Solution
<IfModule mod_php7.c>blocks (3 files)php5.ini<IfModule mod_php.c>blocks (PHP 8+ compatible)Files Changed
pub/.htaccess(remove mod_php7 block, suhosin, PHP 5 CGI/hosting sections)pub/media/.htaccess(remove mod_php7 block)pub/static/.htaccess(remove mod_php7 block)⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz